r2.18 cherry-pick: be4f646ec43 "PR #17430: [ROCm] Use unique_ptr for TupleHandle in pjrt_se_client"#77576
Merged
learning-to-play merged 1 commit intor2.18from Oct 10, 2024
Merged
Conversation
Imported from GitHub PR openxla/xla#17430 On older gcc (specifically in Ubuntu-20.04) and absl copy operator fails to copy created TupleHandle into an existing variable. Instead use unique_ptr to accompalish the same Copybara import of the project: -- 80eb83068d89982a743a69f83af9f351d6a829d6 by Harsha HS <Harsha.HavanurShamsundara@amd.com>: [ROCm] Use unique_ptr for TupleHandle in pjrt_se_client On older gcc (specifically in Ubuntu-20.04) and absl copy operator fails to copy created TupleHandle into an existing variable. Instead use unique_ptr to accompalish the same Merging this change closes #17430 PiperOrigin-RevId: 681556381
learning-to-play
approved these changes
Oct 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refer to the original commit: be4f646