backport: set a minimum long-polling interval for Events in rpc (#8050)#9768
Merged
thanethomson merged 2 commits intotendermint:feature/adr075-backportfrom Dec 7, 2022
Conversation
Since the goal of reading events at the head of the event log is to satisfy a subscription style interface, there is no point in allowing head polling with no wait interval. The pagination case already bypasses long polling, so the extra option is unneessary. Set a minimum default long-polling interval for the head case. Add a test for minimum delay.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
mmsqe
commented
Dec 7, 2022
| maxItems = 100 | ||
| } | ||
|
|
||
| const minWaitTime = 1 * time.Second |
Author
There was a problem hiding this comment.
@cmwaters @sergio-mena feel to ping me if any change is needed
sergio-mena
reviewed
Dec 8, 2022
Contributor
sergio-mena
left a comment
There was a problem hiding this comment.
Sorry for delay on this.
LGTM (thanks @thanethomson)
mmsqe
added a commit
to mmsqe/tendermint
that referenced
this pull request
Dec 9, 2022
…ermint#8050) (tendermint#9768) * rpc: set a minimum long-polling interval for Events (tendermint#8050) Since the goal of reading events at the head of the event log is to satisfy a subscription style interface, there is no point in allowing head polling with no wait interval. The pagination case already bypasses long polling, so the extra option is unneessary. Set a minimum default long-polling interval for the head case. Add a test for minimum delay. * fix doc Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
mmsqe
added a commit
to mmsqe/tendermint
that referenced
this pull request
Dec 9, 2022
…ermint#8050) (tendermint#9768) * rpc: set a minimum long-polling interval for Events (tendermint#8050) Since the goal of reading events at the head of the event log is to satisfy a subscription style interface, there is no point in allowing head polling with no wait interval. The pagination case already bypasses long polling, so the extra option is unneessary. Set a minimum default long-polling interval for the head case. Add a test for minimum delay. * fix doc Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the full description, see #8050
PR checklist
CHANGELOG_PENDING.mdupdated, or no changelog entry neededdocs/) and code comments, or nodocumentation updates needed