rpc: set a minimum long-polling interval for Events#8050
Merged
creachadair merged 2 commits intomasterfrom Mar 2, 2022
Merged
Conversation
b3749e8 to
48a60f0
Compare
cmwaters
reviewed
Mar 2, 2022
tychoish
approved these changes
Mar 2, 2022
Contributor
tychoish
left a comment
There was a problem hiding this comment.
should we write a test for the minim time behavior?
48a60f0 to
17c36d0
Compare
added 2 commits
March 2, 2022 07:33
Since the goal of reading events at the head of the event log is to satisfy a subscription style interface, there is no point in allowing head polling with no wait interval. The pagination case already bypasses long polling, so the extra option is unneessary. Set a minimum default long-polling interval for the head case.
2aa388d to
658fe70
Compare
Author
Good idea, done. |
thanethomson
reviewed
Mar 2, 2022
| maxItems = 100 | ||
| } | ||
|
|
||
| const minWaitTime = 1 * time.Second |
Contributor
There was a problem hiding this comment.
Is there a reason these minimum/maximum wait times are not documented for this function?
Author
There was a problem hiding this comment.
They're an implementation detail, and clients should not be written assuming specific values for them. The service is allowed to change them at will.
mmsqe
pushed a commit
to mmsqe/tendermint
that referenced
this pull request
Sep 2, 2022
Since the goal of reading events at the head of the event log is to satisfy a subscription style interface, there is no point in allowing head polling with no wait interval. The pagination case already bypasses long polling, so the extra option is unneessary. Set a minimum default long-polling interval for the head case. Add a test for minimum delay.
mmsqe
pushed a commit
to mmsqe/tendermint
that referenced
this pull request
Sep 2, 2022
Since the goal of reading events at the head of the event log is to satisfy a subscription style interface, there is no point in allowing head polling with no wait interval. The pagination case already bypasses long polling, so the extra option is unneessary. Set a minimum default long-polling interval for the head case. Add a test for minimum delay.
mmsqe
pushed a commit
to mmsqe/tendermint
that referenced
this pull request
Nov 26, 2022
Since the goal of reading events at the head of the event log is to satisfy a subscription style interface, there is no point in allowing head polling with no wait interval. The pagination case already bypasses long polling, so the extra option is unneessary. Set a minimum default long-polling interval for the head case. Add a test for minimum delay.
3 tasks
thanethomson
pushed a commit
that referenced
this pull request
Dec 7, 2022
… (#9768) * rpc: set a minimum long-polling interval for Events (#8050) Since the goal of reading events at the head of the event log is to satisfy a subscription style interface, there is no point in allowing head polling with no wait interval. The pagination case already bypasses long polling, so the extra option is unneessary. Set a minimum default long-polling interval for the head case. Add a test for minimum delay. * fix doc Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
mmsqe
added a commit
to mmsqe/tendermint
that referenced
this pull request
Dec 9, 2022
…ermint#8050) (tendermint#9768) * rpc: set a minimum long-polling interval for Events (tendermint#8050) Since the goal of reading events at the head of the event log is to satisfy a subscription style interface, there is no point in allowing head polling with no wait interval. The pagination case already bypasses long polling, so the extra option is unneessary. Set a minimum default long-polling interval for the head case. Add a test for minimum delay. * fix doc Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
mmsqe
added a commit
to mmsqe/tendermint
that referenced
this pull request
Dec 9, 2022
…ermint#8050) (tendermint#9768) * rpc: set a minimum long-polling interval for Events (tendermint#8050) Since the goal of reading events at the head of the event log is to satisfy a subscription style interface, there is no point in allowing head polling with no wait interval. The pagination case already bypasses long polling, so the extra option is unneessary. Set a minimum default long-polling interval for the head case. Add a test for minimum delay. * fix doc Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the goal of reading events at the head of the event log is to satisfy a
subscription style interface, there is no point in allowing head polling with
no wait interval. The pagination case already bypasses long polling, so the
extra option is unneessary.
Set a minimum default long-polling interval for the head case.