backport: add event subscription options and defaults config (#7930)#9491
Conversation
|
@sergio-mena may I ask if I could merge the rest backports into one for faster review? |
Yes, makes sense. We are at the end of the quarter and I can't guarantee a timely review (I'm reviewing this PR now). However, for the sake of clarity and traceability, please include each backported PR into its own commit in the new PR. |
sergio-mena
left a comment
There was a problem hiding this comment.
Thanks for this work
CHANGELOG_PENDING.md
Outdated
| ### BREAKING CHANGES | ||
|
|
||
| - CLI/RPC/Config | ||
| - [config] \#7930 Add new event subscription options and defaults. (@creachadair) |
| rpcserver.ReadLimit(config.MaxBodyBytes), | ||
| rpcserver.WriteChanCapacity(n.config.RPC.WebSocketWriteBufferSize), | ||
| ) | ||
| wm.SetLogger(wmLogger) |
There was a problem hiding this comment.
Similarly, to my comment in line 1133, wouldn't we want to keep this line?
| } | ||
| }), | ||
| rpcserver.ReadLimit(config.MaxBodyBytes), | ||
| rpcserver.WriteChanCapacity(n.config.RPC.WebSocketWriteBufferSize), |
There was a problem hiding this comment.
This line wasn't on the original PR, so you might want to keep it after this PR.
From a purely "backporting" point of view, it does make a lot of sense to keep this line.
sergio-mena
left a comment
There was a problem hiding this comment.
From a backporting point of view, this is ready for merging
…int#7930) (tendermint#9491) * config: add event subscription options and defaults (tendermint#7930) * Apply suggestions from code review Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
…int#7930) (tendermint#9491) * config: add event subscription options and defaults (tendermint#7930) * Apply suggestions from code review Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
For the full description, see #7930
PR checklist
CHANGELOG_PENDING.mdupdated, or no changelog entry neededdocs/) and code comments, or nodocumentation updates needed