config: add event subscription options and defaults#7930
Conversation
72ba9b5 to
6718610
Compare
cmwaters
left a comment
There was a problem hiding this comment.
This looks all good to me. A question that occurred is about the light client. Historically, we've endeavoured to have the same RPC API as a full node, simply forwarding the requests and verifying them if possible. How will this work with the /events endpoint?
It should be the same. The light client has no event log of its own, so it will forward the arguments to the server on the node it's hitched to. That should work transparently. #7801 has the rest of the changes these PRs are being pulled from if you want to see the rest of the implementation so far. I did update the light client along with the rest. |
…int#7930) (tendermint#9491) * config: add event subscription options and defaults (tendermint#7930) * Apply suggestions from code review Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
…int#7930) (tendermint#9491) * config: add event subscription options and defaults (tendermint#7930) * Apply suggestions from code review Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
This is part of the implementation of ADR-075. This change adds the configuration settings that will be used by the event log, and hooks up an experimental switch to disable websocket export.
See specifically the Discussion section for background on these config settings.