config: Move discard_abci_responses flag into its own storage section#9275
Merged
thanethomson merged 2 commits intov0.34.xfrom Aug 17, 2022
Merged
config: Move discard_abci_responses flag into its own storage section#9275thanethomson merged 2 commits intov0.34.xfrom
discard_abci_responses flag into its own storage section#9275thanethomson merged 2 commits intov0.34.xfrom
Conversation
Signed-off-by: Thane Thomson <connect@thanethomson.com>
cmwaters
approved these changes
Aug 17, 2022
Contributor
cmwaters
left a comment
There was a problem hiding this comment.
Awesome. Thanks for doing that. Had half started last night but this is basically exactly how I had done it. I had even positioned this section specifically below the consensus config lol
config/toml.go
Outdated
Comment on lines
+487
to
+489
| # Set to false to ensure ABCI responses are persisted. ABCI responses are | ||
| # required for /block_results RPC queries, and to reindex events in the | ||
| # command-line tool. |
Contributor
There was a problem hiding this comment.
Can we mention that setting this to true will save considerable disk space (or something similar)
Contributor
Author
There was a problem hiding this comment.
Does the new comment seem reasonable?
Signed-off-by: Thane Thomson <connect@thanethomson.com>
cmwaters
approved these changes
Aug 17, 2022
Contributor
cmwaters
left a comment
There was a problem hiding this comment.
Yup the comments look good
samricotta
pushed a commit
that referenced
this pull request
Aug 18, 2022
…on (#9275) * config: Move discard_abci_responses flag into its own storage section Signed-off-by: Thane Thomson <connect@thanethomson.com> * Update config comment to highlight space saving tradeoff Signed-off-by: Thane Thomson <connect@thanethomson.com> Signed-off-by: Thane Thomson <connect@thanethomson.com>
samricotta
pushed a commit
that referenced
this pull request
Aug 18, 2022
…on (#9275) * config: Move discard_abci_responses flag into its own storage section Signed-off-by: Thane Thomson <connect@thanethomson.com> * Update config comment to highlight space saving tradeoff Signed-off-by: Thane Thomson <connect@thanethomson.com> Signed-off-by: Thane Thomson <connect@thanethomson.com>
samricotta
pushed a commit
that referenced
this pull request
Aug 19, 2022
…on (#9275) * config: Move discard_abci_responses flag into its own storage section Signed-off-by: Thane Thomson <connect@thanethomson.com> * Update config comment to highlight space saving tradeoff Signed-off-by: Thane Thomson <connect@thanethomson.com> Signed-off-by: Thane Thomson <connect@thanethomson.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9274
Docs and
CHANGELOG_PENDINGentry will be added in #9267.PR checklist
CHANGELOG_PENDING.mdupdated, or no changelog entry neededdocs/) and code comments, or nodocumentation updates needed