docs: Minor recommendations prior to v0.34.21 release#9267
docs: Minor recommendations prior to v0.34.21 release#9267thanethomson merged 8 commits intov0.34.xfrom
Conversation
511ca81 to
1d19ac9
Compare
CHANGELOG_PENDING.md
Outdated
| - A new RPC configuration flag, `discard_abci_responses`, which, if enabled, | ||
| discards all ABCI responses except the latest one in order to reduce disk | ||
| space usage in the state store. Note that, if enabled, this means that the | ||
| `block_results` RPC endpoint will only be able to return the latest block. |
There was a problem hiding this comment.
Actually if enabled /block_results will return an error saying that the node isn't persisting abci responses
There was a problem hiding this comment.
I wonder if adding the RPC part is confusing. Yes it's in the RPC section but that's because we didn't want to create a new section and wasn't sure where such a change would best fit so we landed it in RPC but really this is a storage engine config
There was a problem hiding this comment.
Actually if enabled
/block_resultswill return an error saying that the node isn't persisting abci responses
Ah, I missed this somehow. In terms of the way it's implemented now though, does this make sense given that we do actually store the last ABCI response and can actually give the latest block results? Should we really always be returning an error if we have the results? (Mainly asking for context around the decision-making there)
I wonder if adding the RPC part is confusing. Yes it's in the RPC section but that's because we didn't want to create a new section
Is it really a big deal to create a new section, especially when the flag's off by default? I'd say that, since it's technically a state store option, so it could either go into a [statestore] section, or more generically a [storage] section.
There was a problem hiding this comment.
Ah, I missed this somehow. In terms of the way it's implemented now though, does this make sense given that we do actually store the last ABCI response and can actually give the latest block results? Should we really always be returning an error if we have the results? (Mainly asking for context around the decision-making there)
We definitely could. There needs to be some added logic but it's possible. The design decision was one of simplicity - easier just to close of the entire RPC endpoint than to have it error for every height except the latest
There was a problem hiding this comment.
Is it really a big deal to create a new section, especially when the flag's off by default? I'd say that, since it's technically a state store option, so it could either go into a [statestore] section, or more generically a [storage] section.
It's possible to maybe have a general storage section. It's not clear to me yet what other configuration options there might be
There was a problem hiding this comment.
We definitely could. There needs to be some added logic but it's possible.
Speaking to the IBC-rs team now, it may actually be better to just keep it as-is. The relayer could then just ping the /block_results endpoint on startup and, if it errors out with the current error, they can notify the user that the relevant node isn't correctly configured.
8ba7205 to
1794237
Compare
CHANGELOG_PENDING.md
Outdated
| - A new RPC configuration flag, `discard_abci_responses`, which, if enabled, | ||
| discards all ABCI responses except the latest one in order to reduce disk | ||
| space usage in the state store. Note that, if enabled, this means that the | ||
| `block_results` RPC endpoint will only be able to return the latest block. |
cmwaters
left a comment
There was a problem hiding this comment.
Need to update a few things given recent changes but looks good other than that
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
1794237 to
20ec497
Compare
Signed-off-by: Thane Thomson <connect@thanethomson.com>
In preparation for the v0.34.21 release, I was looking through the changes and thought we could better document them.
PR checklist
CHANGELOG_PENDING.mdupdated, or no changelog entry neededdocs/) and code comments, or nodocumentation updates needed