Skip to content

remove lastresulthash from merklization in lastresult hash#9175

Merged
mergify[bot] merged 7 commits intomainfrom
marko/remove_gas
Aug 9, 2022
Merged

remove lastresulthash from merklization in lastresult hash#9175
mergify[bot] merged 7 commits intomainfrom
marko/remove_gas

Conversation

@tac0turtle
Copy link
Contributor

@tac0turtle tac0turtle commented Aug 5, 2022

remove gas from merklization in headers

Im not sure where to change docs since main points to the spec repo but that repo is archived. Maybe someone can help me?

@tac0turtle tac0turtle marked this pull request as ready for review August 5, 2022 18:16
@tac0turtle tac0turtle requested a review from ebuchman as a code owner August 5, 2022 18:16
@tac0turtle tac0turtle requested a review from a team August 5, 2022 18:16
@tac0turtle
Copy link
Contributor Author

ah its already in the spec but we were actually doing gas and gas wanted on top

Both the `Code` and `Data` are included in a structure that is hashed into the

@cmwaters cmwaters requested a review from a team August 8, 2022 10:28
Copy link
Contributor

@cmwaters cmwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spec repo is merged into this repo. You can find it under /spec. I have already made the updates

@tac0turtle tac0turtle added the S:automerge Automatically merge PR when requirements pass label Aug 8, 2022
@mergify mergify bot merged commit bff63ae into main Aug 9, 2022
@mergify mergify bot deleted the marko/remove_gas branch August 9, 2022 08:16
samricotta pushed a commit that referenced this pull request Aug 9, 2022
remove gas from merklization in headers

Im not sure where to change docs since main points to the spec repo but that repo is archived. Maybe someone can help me?
samricotta pushed a commit that referenced this pull request Aug 10, 2022
remove gas from merklization in headers


Im not sure where to change docs since main points to the spec repo but that repo is archived. Maybe someone can help me?
samricotta pushed a commit that referenced this pull request Aug 11, 2022
remove gas from merklization in headers


Im not sure where to change docs since main points to the spec repo but that repo is archived. Maybe someone can help me?
samricotta pushed a commit that referenced this pull request Aug 11, 2022
remove gas from merklization in headers


Im not sure where to change docs since main points to the spec repo but that repo is archived. Maybe someone can help me?
samricotta pushed a commit that referenced this pull request Aug 12, 2022
remove gas from merklization in headers


Im not sure where to change docs since main points to the spec repo but that repo is archived. Maybe someone can help me?
samricotta pushed a commit that referenced this pull request Aug 12, 2022
remove gas from merklization in headers

Im not sure where to change docs since main points to the spec repo but that repo is archived. Maybe someone can help me?
samricotta pushed a commit that referenced this pull request Aug 16, 2022
remove gas from merklization in headers

Im not sure where to change docs since main points to the spec repo but that repo is archived. Maybe someone can help me?
@thanethomson thanethomson mentioned this pull request Aug 18, 2022
39 tasks
thanethomson added a commit that referenced this pull request Aug 24, 2022
…9175)"

This reverts commit bff63ae.

Signed-off-by: Thane Thomson <connect@thanethomson.com>
thanethomson added a commit that referenced this pull request Aug 24, 2022
…lastresult hash (#9313)

* Revert "remove lastresulthash from merklization in lastresult hash (#9175)"

This reverts commit bff63ae.

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Clarify wording in ABCI upgrade guidelines

Signed-off-by: Thane Thomson <connect@thanethomson.com>

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S:automerge Automatically merge PR when requirements pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants