Temporarily revert #9175: remove lastresulthash from merklization in lastresult hash#9313
Merged
thanethomson merged 2 commits intomainfrom Aug 24, 2022
Merged
Temporarily revert #9175: remove lastresulthash from merklization in lastresult hash#9313thanethomson merged 2 commits intomainfrom
thanethomson merged 2 commits intomainfrom
Conversation
Signed-off-by: Thane Thomson <connect@thanethomson.com>
sergio-mena
reviewed
Aug 24, 2022
Comment on lines
+13
to
+14
| * Added `AbciVersion` to `RequestInfo`. Applications should check that the ABCI | ||
| version they expect is being used in order to ensure compatibility. |
Contributor
There was a problem hiding this comment.
I'd have a minor suggestion for wording this, but I guess it's best if I rework this as part of the task we discussed yesterday (UPGRADING + CHANGELOG, see #9304)
Contributor
Author
There was a problem hiding this comment.
Oh feel free to change that when you address #9304 👍
sergio-mena
approved these changes
Aug 24, 2022
Contributor
sergio-mena
left a comment
There was a problem hiding this comment.
Thanks for this @thanethomson !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #9091.
We will look at reintroducing this in a subsequent release, possibly part of the larger effort described in #9257.
PR checklist
CHANGELOG_PENDING.mdupdated, or no changelog entry neededdocs/) and code comments, or nodocumentation updates needed