Backport of sam/abci-responses (#9090)#9159
Conversation
config/config.go
Outdated
| // Set false to ensure ABCI responses are persisted. | ||
| // ABCI responses are required for /BlockResults RPC queries, and | ||
| // to reindex events in the command-line tool. | ||
| DiscardABCIResponses bool `mapstructure:"persist-abci-responses"` |
There was a problem hiding this comment.
| // Set false to ensure ABCI responses are persisted. | |
| // ABCI responses are required for /BlockResults RPC queries, and | |
| // to reindex events in the command-line tool. | |
| DiscardABCIResponses bool `mapstructure:"persist-abci-responses"` | |
| // Set false to ensure ABCI responses are persisted. | |
| // ABCI responses are required for /BlockResults RPC queries, and | |
| // to reindex events in the command-line tool. | |
| DiscardABCIResponses bool `mapstructure:"discard_abci_responses"` |
The keys changed from this_style to this-style between releases. I'm also realizing that the config key is persist-abci-responses but the field name is DiscardABCIResponses which have opposite meanings. I think we should change the key to match the field name.
There was a problem hiding this comment.
Yeah this completely makes sense, Ill make those updates
williambanfield
left a comment
There was a problem hiding this comment.
Looks like it needs to have gofmt run in a few spots. Should be good after that.
| var ( | ||
| stateKey = []byte("stateKey") | ||
| ) | ||
| // database key |
state/store.go
Outdated
| const ( | ||
| prefixValidators = int64(5) | ||
| prefixConsensusParams = int64(6) | ||
| prefixAllABCIResponses = int64(7) | ||
| prefixState = int64(8) | ||
| prefixLastABCIResponse = int64(13) | ||
| ) |
There was a problem hiding this comment.
You need to use all the old prefixes and key encodings
There was a problem hiding this comment.
We should probably even have tests that ensure keys don't change throughout a release
|
Should we instead be porting this into |
|
My thought was to get it out in v0.34.21 as well so we get it into users hands quicker |
cmwaters
left a comment
There was a problem hiding this comment.
Looks good. Just a few nits
…dermint into abci-responses-flag-merge
4292895 to
1c98260
Compare
Backport of
sam/abci-responses#9090