Optimize ABCI Response Information and flag to save ABCI results #8028 #8946#9090
Merged
samricotta merged 29 commits intov0.35.xfrom Aug 2, 2022
Merged
Optimize ABCI Response Information and flag to save ABCI results #8028 #8946#9090samricotta merged 29 commits intov0.35.xfrom
samricotta merged 29 commits intov0.35.xfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #8028, #8946
Adds a flag to the config.go which enables discarding of abci responses. This flag is used when saving and loading the abciresponses to overwrite the current abciresponses with the last response. This way the node operator can decide if they would like to save or discard the responses for efficiency purposes.
(@cmwaters) NOTE: A different solution is used for ABCI++ branches whereby the last ABCI responses are not needed for crash recovery