abci: implement process proposal to spec#9122
Merged
cmwaters merged 23 commits intofeature/abci++pppfrom Aug 9, 2022
Merged
Conversation
add processproposal proto/boilerplate/logic mockery gofmt fix test gofmt move UNKNOWN response behaviour to reject
Contributor
Author
|
Looking through the changes, I think we're light on tests in the consensus package. I would like to mock out the application and test some variations of the new calls but I want to do this in a separate PR. |
williambanfield
suggested changes
Aug 3, 2022
Contributor
williambanfield
left a comment
There was a problem hiding this comment.
Should port the changes @sergio-mena suggested. Looks great beyond that.
williambanfield
suggested changes
Aug 8, 2022
Contributor
williambanfield
left a comment
There was a problem hiding this comment.
It looks like a few changes unrelated to ABCI++ were mixed in here, some of which have already landed in main . I don't think they are necessary to do again here since this will be merged into main anyway.
A few notes otherwise, but mostly looks good.
2dd5a83 to
4be2e22
Compare
williambanfield
approved these changes
Aug 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #9121
Ref: #9053