state/types: refactor makeBlock, makeBlocks and makeTxs#6567
Merged
mergify[bot] merged 2 commits intotendermint:masterfrom Jun 11, 2021
Merged
state/types: refactor makeBlock, makeBlocks and makeTxs#6567mergify[bot] merged 2 commits intotendermint:masterfrom
mergify[bot] merged 2 commits intotendermint:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6567 +/- ##
==========================================
- Coverage 61.22% 61.19% -0.04%
==========================================
Files 295 295
Lines 27848 27847 -1
==========================================
- Hits 17049 17040 -9
- Misses 9084 9097 +13
+ Partials 1715 1710 -5
|
cmwaters
approved these changes
Jun 11, 2021
Contributor
cmwaters
left a comment
There was a problem hiding this comment.
Nice job 👍
I'm not too sure how much of these test helpers we want to expose for external users. There's been a lot of recent discussion surrounding internalisation and I think testing is another part of this that we should probably have a short discussion about
alexanderbez
approved these changes
Jun 11, 2021
sergio-mena
pushed a commit
that referenced
this pull request
Jul 27, 2022
sergio-mena
pushed a commit
that referenced
this pull request
Jul 27, 2022
sergio-mena
pushed a commit
that referenced
this pull request
Jul 29, 2022
sergio-mena
pushed a commit
that referenced
this pull request
Aug 3, 2022
sergio-mena
pushed a commit
that referenced
this pull request
Aug 3, 2022
3 tasks
sergio-mena
added a commit
that referenced
this pull request
Aug 3, 2022
* ----start---- * [PARTIAL cherry-pick] ABCI Vote Extension 2 (#6885) * Cherry-picked #6567: state/types: refactor makeBlock, makeBlocks and makeTxs (#6567) * [Cherrypicked] types: remove panic from block methods (#7501) * [cherrypicked] abci++: synchronize PrepareProposal with the newest version of the spec (#8094) This change implements the logic for the PrepareProposal ABCI++ method call. The main logic for creating and issuing the PrepareProposal request lives in execution.go and is tested in a set of new tests in execution_test.go. This change also updates the mempool mock to use a mockery generated version and removes much of the plumbing for the no longer used ABCIResponses. * make proto-gen * Backported EvidenceList's method ToABCI from #7961 * make build * Fix mockery for Mempool * mockery * Backported abci Application mocks from #7961 * mockery2 * Fixed new PrepareProposal test cases in state/execution_test.go * Fixed returned errors in consensus/state.go * lint * Addressed @cmwaters' comment Co-authored-by: mconcat <monoidconcat@gmail.com> Co-authored-by: JayT106 <JayT106@users.noreply.github.com> Co-authored-by: Sam Kleinman <garen@tychoish.com> Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com>
samricotta
pushed a commit
that referenced
this pull request
Aug 16, 2022
* ----start---- * [PARTIAL cherry-pick] ABCI Vote Extension 2 (#6885) * Cherry-picked #6567: state/types: refactor makeBlock, makeBlocks and makeTxs (#6567) * [Cherrypicked] types: remove panic from block methods (#7501) * [cherrypicked] abci++: synchronize PrepareProposal with the newest version of the spec (#8094) This change implements the logic for the PrepareProposal ABCI++ method call. The main logic for creating and issuing the PrepareProposal request lives in execution.go and is tested in a set of new tests in execution_test.go. This change also updates the mempool mock to use a mockery generated version and removes much of the plumbing for the no longer used ABCIResponses. * make proto-gen * Backported EvidenceList's method ToABCI from #7961 * make build * Fix mockery for Mempool * mockery * Backported abci Application mocks from #7961 * mockery2 * Fixed new PrepareProposal test cases in state/execution_test.go * Fixed returned errors in consensus/state.go * lint * Addressed @cmwaters' comment Co-authored-by: mconcat <monoidconcat@gmail.com> Co-authored-by: JayT106 <JayT106@users.noreply.github.com> Co-authored-by: Sam Kleinman <garen@tychoish.com> Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3584