Skip to content

state/types: Move all makeX functions into X/test_helpers.go #3584

New issue
New issue
Closed
#6567
#3819
Closed
state/types: Move all makeX functions into X/test_helpers.go#3584
#6567
#3819
Labels
S:proposalStatus: ProposalT:code-hygieneGeneral cleanup and restructuring of code to provide clarity, flexibility, and modularity.T:jankType Jank! Non-urgent but still high-impact fixes.T:testType: Tests that need love
@melekes

Description

@melekes
melekes
opened on Apr 22, 2019

https://github.com/tendermint/tendermint/blob/develop/consensus/replay_test.go#L551

state/test_helpers.go:

  • makeBlocks (chain of blocks)
  • makeBlock

types/test_helpers.go:

  • makeVote

This should reduce code duplication.

Metadata

Metadata

Assignees

No one assigned

    Labels

    S:proposalStatus: ProposalT:code-hygieneGeneral cleanup and restructuring of code to provide clarity, flexibility, and modularity.T:jankType Jank! Non-urgent but still high-impact fixes.T:testType: Tests that need love

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions