makefile: change buf to use tools.go ; backport v0.34#8852
makefile: change buf to use tools.go ; backport v0.34#8852jmalicevic merged 3 commits intov0.34.xfrom
Conversation
This will keep the version of `buf` consistent between all developer machines.
| .PHONY: proto-gen | ||
|
|
||
| proto-lint: | ||
| @$(DOCKER_BUF) check lint --error-format=json |
There was a problem hiding this comment.
Is DOCKER_BUF referenced anywhere else in this makefile? If not, let's delete the variable.
There was a problem hiding this comment.
It is referenced below in check-proto-breaking-ci . However this command does not exist anymore in master. Do you think we should delete both that and the variable?
There was a problem hiding this comment.
Just saw that this exists in 0.35 so I will merge it as is.
Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com>
|
@tychoish, @creachadair , @williambanfield , turns out it is not so straight forward to get this to actually work. I had to introduce a few more changes in the backport PR (#8695 ) to get the bufs to work. Before i repeat this in this branch, can someone please take a look at the changes in Makefile? I am sure there is a better way to install the deps then from the Makefile directly. 0.36 has proto-gen.sh for this, 0.34 does not. Also, should we delete all references to docker when it comes to proto (.github/workflow/proto-docker; scripts/protocgen.sh)? |
…608) * fix so that vektra/mockery/v2 isn't erased by `go mod tidy` * backport tendermint/tendermint#8852 --------- Co-authored-by: TAKAMI Torao <koiroha@gmail.com>
Closes #8850
The CI in 0.34 was failing due to an update to buf.