feat: v0.34.x Prioritized Mempool#8695
Conversation
cmwaters
left a comment
There was a problem hiding this comment.
Just done a brief pass, are we still giving the user the option between the new and old mempool or are you modifying it so it's a straight swap?
| // mempool_error is set by Tendermint. | ||
| // ABCI applictions creating a ResponseCheckTX should not set mempool_error. | ||
| string mempool_error = 11; |
There was a problem hiding this comment.
We removed this for v0.36 but I think it's fine if we just leave it for now since it's also in v0.35
There was a problem hiding this comment.
Yes, the way I'm doing this PR is just dropping in the entire mempool from 0.35.x into 0.34.x, modulo any API changes necessary.
| repeated Event events = 7 | ||
| [(gogoproto.nullable) = false, (gogoproto.jsontag) = "events,omitempty"]; | ||
| string codespace = 8; | ||
| string sender = 9; |
There was a problem hiding this comment.
No, but this is a drop-in placement of what 0.35.x has.
Straight swap. Would you like to support both? |
|
@cmwaters I have v0 and v1 introduced into this PR now. It still needs work to get it to build and update all the APIs. Honestly, it's more work than I anticipated and I don't really have the capacity to push it over the finish line. What's left to complete:
|
|
Hi @alexanderbez , @cmwaters , |
I don't think I have the privileges to trigger the workflows. The plumbing is done in #8863 but I can't trigger the additional workflows. |
|
We cannot merge this until #8863 is closed but as the issue is urgent, I will open it for review as all mempool related things are done and tests are passing. |
Signed-off-by: Thane Thomson <connect@thanethomson.com>
thanethomson
left a comment
There was a problem hiding this comment.
Approving, given the current gameplan that this will only be released in an RC and will not make it into any releases until #8775 is resolved.
cmwaters
left a comment
There was a problem hiding this comment.
I think the other thing we'll need to cover are the docs but we can do it as a separate PR
This is a drop-in version of the prioritized mempool introduced in TM v0.35.x retrofitted for the TM v0.34.x release line. That being the case, there exists no new logic here.
Core files/diffs to review:
mempool/reactor.gomempool/clist_mempool.go