abci++: add proto fields for enabling vote extensions#8587
Merged
mergify[bot] merged 24 commits intomasterfrom May 23, 2022
Merged
abci++: add proto fields for enabling vote extensions#8587mergify[bot] merged 24 commits intomasterfrom
mergify[bot] merged 24 commits intomasterfrom
Conversation
williambanfield
commented
May 20, 2022
creachadair
approved these changes
May 21, 2022
sergio-mena
reviewed
May 23, 2022
| // vote extensions will be enabled. During this specified height, and for all | ||
| // subsequent heights, precommit messages that do not contain valid extension data | ||
| // will be considered invalid. Prior to this height, vote extensions will not | ||
| // be used or accepted by validators on the network. |
Contributor
There was a problem hiding this comment.
Could you add a sentence clarifying that PrepareProposal won't accept extension at that particular height?
sergio-mena
reviewed
May 23, 2022
sergio-mena
reviewed
May 23, 2022
sergio-mena
reviewed
May 23, 2022
sergio-mena
reviewed
May 23, 2022
sergio-mena
reviewed
May 23, 2022
| params.ABCI.VoteExtensionsEnableHeight, h) | ||
| } | ||
| if params.ABCI.VoteExtensionsEnableHeight <= h { | ||
| return fmt.Errorf("VoteExtensionsEnableHeight cannot be updated modified once"+ |
Contributor
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("VoteExtensionsEnableHeight cannot be updated modified once"+ | |
| return fmt.Errorf("VoteExtensionsEnableHeight cannot be modified once "+ |
sergio-mena
approved these changes
May 23, 2022
17 tasks
3 tasks
cmwaters
pushed a commit
that referenced
this pull request
Nov 15, 2022
This pull requests adds the protocol buffer field for the `ABCI.VoteExtensionsEnableHeight` parameter. This proto field is threaded throughout all of the relevant places where consensus params are used and referenced. This PR also adds validation of the consensus param updates. Previous consensus param changes didn't depend on _previous_ versions of the params, so this change adds a method for validating against the old params as well. closes: #8453
sergio-mena
pushed a commit
that referenced
this pull request
Nov 28, 2022
This pull requests adds the protocol buffer field for the `ABCI.VoteExtensionsEnableHeight` parameter. This proto field is threaded throughout all of the relevant places where consensus params are used and referenced. This PR also adds validation of the consensus param updates. Previous consensus param changes didn't depend on _previous_ versions of the params, so this change adds a method for validating against the old params as well. closes: #8453
sergio-mena
pushed a commit
that referenced
this pull request
Nov 30, 2022
…#8587) This pull requests adds the protocol buffer field for the `ABCI.VoteExtensionsEnableHeight` parameter. This proto field is threaded throughout all of the relevant places where consensus params are used and referenced. This PR also adds validation of the consensus param updates. Previous consensus param changes didn't depend on _previous_ versions of the params, so this change adds a method for validating against the old params as well. closes: #8453
sergio-mena
pushed a commit
that referenced
this pull request
Dec 9, 2022
…#8587) This pull requests adds the protocol buffer field for the `ABCI.VoteExtensionsEnableHeight` parameter. This proto field is threaded throughout all of the relevant places where consensus params are used and referenced. This PR also adds validation of the consensus param updates. Previous consensus param changes didn't depend on _previous_ versions of the params, so this change adds a method for validating against the old params as well. closes: #8453
3 tasks
sergio-mena
added a commit
that referenced
this pull request
Dec 13, 2022
* [cherry-picked] abci++: add proto fields for enabling vote extensions (#8587) This pull requests adds the protocol buffer field for the `ABCI.VoteExtensionsEnableHeight` parameter. This proto field is threaded throughout all of the relevant places where consensus params are used and referenced. This PR also adds validation of the consensus param updates. Previous consensus param changes didn't depend on _previous_ versions of the params, so this change adds a method for validating against the old params as well. closes: #8453 * Re-sync some things with original patch * fixes * Remove 'Skip' from TestApp_VoteExtensions * Fix all unit tests * Appease linter * Update types/params.go Co-authored-by: Thane Thomson <connect@thanethomson.com> Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com> Co-authored-by: Thane Thomson <connect@thanethomson.com>
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull requests adds the protocol buffer field for the
ABCI.VoteExtensionsEnableHeightparameter. This proto field is threaded throughout all of the relevant places where consensus params are used and referenced.This PR also adds validation of the consensus param updates. Previous consensus param changes didn't depend on previous versions of the params, so this change adds a method for validating against the old params as well.
closes: #8453