Vote extensions: add proto fields for enabling extensions#9865
Merged
sergio-mena merged 7 commits intofeature/abci++veffrom Dec 13, 2022
Merged
Vote extensions: add proto fields for enabling extensions#9865sergio-mena merged 7 commits intofeature/abci++veffrom
sergio-mena merged 7 commits intofeature/abci++veffrom
Conversation
…#8587) This pull requests adds the protocol buffer field for the `ABCI.VoteExtensionsEnableHeight` parameter. This proto field is threaded throughout all of the relevant places where consensus params are used and referenced. This PR also adds validation of the consensus param updates. Previous consensus param changes didn't depend on _previous_ versions of the params, so this change adds a method for validating against the old params as well. closes: #8453
lasarojc
reviewed
Dec 12, 2022
| return false | ||
| } | ||
| } | ||
| if that1 == nil { |
Contributor
There was a problem hiding this comment.
can that pass the test in 664 and we still have that1 be nil here?
Contributor
Author
There was a problem hiding this comment.
Hi Lásaro, this is autogenerated code from protobufs, so we can't really change it
(we commit the autogenerated code because we chose not to require end users to install the toolchain to generate the code at every build)
lasarojc
reviewed
Dec 12, 2022
Comment on lines
+682
to
+685
| if this.VoteExtensionsEnableHeight != that1.VoteExtensionsEnableHeight { | ||
| return false | ||
| } | ||
| return true |
Contributor
There was a problem hiding this comment.
would
Suggested change
| if this.VoteExtensionsEnableHeight != that1.VoteExtensionsEnableHeight { | |
| return false | |
| } | |
| return true | |
| return this.VoteExtensionsEnableHeight == that1.VoteExtensionsEnableHeight |
be idiomatic?
Contributor
Author
There was a problem hiding this comment.
Same here, autogenerated code
thanethomson
approved these changes
Dec 12, 2022
Contributor
thanethomson
left a comment
There was a problem hiding this comment.
Did a side-by-side diff of the two PRs. LGTM!
Co-authored-by: Thane Thomson <connect@thanethomson.com>
Contributor
Author
|
Will post a PR reducing/eliminating the flakiness of |
This was referenced Dec 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9864
The first commit is a cherry-pick of #8587.
Subsequent commits are fixing the build and the unit tests
This PR is best reviewed with a diff-of-diffs with the original PR.
N.B: The changelog will be updated once branch
feature/abci++vefis merged back intomainPR checklist
CHANGELOG_PENDING.mdupdated, or no changelog entry neededdocs/) and code comments, or nodocumentation updates needed