Completed the existing FinalizeBlock PR and rebased to master#7798
Merged
sergio-mena merged 13 commits intomasterfrom Feb 14, 2022
Merged
Completed the existing FinalizeBlock PR and rebased to master#7798sergio-mena merged 13 commits intomasterfrom
FinalizeBlock PR and rebased to master#7798sergio-mena merged 13 commits intomasterfrom
Conversation
williambanfield
approved these changes
Feb 11, 2022
Contributor
williambanfield
left a comment
There was a problem hiding this comment.
Nothing concerning. Nice job on getting the rebase all working!
migrate abci to finalizeBlock work on abci, proxy and mempool abciresponse, blok events, indexer, some tests fix some tests fix errors fix errors in abci fix tests amd errors
Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com>
b19e99a to
45fe5b5
Compare
4 tasks
17 tasks
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is rebasing PR #6546 implementing
FinalizeBlockThe logic here is out of sync with the current ABCI++ spec, but rebasing the existing implementation is a first step to filling the gap between spec and implementation, which will be addressed via another issue (#7658)
Additionally, there were some parts of the code that needed completion so that all UTs passed
This addresses #7736