Skip to content

abci: finalize block#6546

Closed
tac0turtle wants to merge 10 commits intoabci++from
finalizeBlock
Closed

abci: finalize block#6546
tac0turtle wants to merge 10 commits intoabci++from
finalizeBlock

Conversation

@tac0turtle
Copy link
Contributor

@tac0turtle tac0turtle commented Jun 7, 2021

Description

Add finalize block

ref #6066

TODO:

  • update apps
  • update tests
  • update e2e
  • make it work.

@github-actions
Copy link

github-actions bot commented Jun 19, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale for use by stalebot label Jun 19, 2021
@tac0turtle tac0turtle removed the stale for use by stalebot label Jun 23, 2021
@github-actions
Copy link

github-actions bot commented Jul 4, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale for use by stalebot label Jul 4, 2021
@tac0turtle tac0turtle removed the stale for use by stalebot label Jul 5, 2021
@liamsi liamsi mentioned this pull request Jul 16, 2021
Closed
@github-actions
Copy link

github-actions bot commented Jul 26, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale for use by stalebot label Jul 26, 2021
@github-actions github-actions bot closed this Jul 31, 2021
@tac0turtle tac0turtle reopened this Jul 31, 2021
@tac0turtle tac0turtle removed the stale for use by stalebot label Jul 31, 2021
@github-actions
Copy link

github-actions bot commented Aug 11, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale for use by stalebot label Aug 11, 2021
@tac0turtle tac0turtle removed the stale for use by stalebot label Aug 13, 2021
@github-actions
Copy link

github-actions bot commented Aug 24, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale for use by stalebot label Aug 24, 2021
@cmwaters cmwaters removed the stale for use by stalebot label Aug 24, 2021
@github-actions
Copy link

github-actions bot commented Sep 4, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale for use by stalebot label Sep 4, 2021
@github-actions github-actions bot closed this Sep 9, 2021
@sergio-mena sergio-mena mentioned this pull request Jan 21, 2022
Closed
4 tasks
@sergio-mena sergio-mena mentioned this pull request Jan 31, 2022
Closed
4 tasks
@sergio-mena sergio-mena deleted the finalizeBlock branch February 4, 2022 16:40
sergio-mena pushed a commit that referenced this pull request Feb 10, 2022
@tac0turtle @sergio-mena
Rebased and git-squashed the commits in PR #6546
44b0666 
migrate abci to finalizeBlock

work on abci, proxy and mempool

abciresponse, blok events, indexer, some tests

fix some tests

fix errors

fix errors in abci

fix tests amd errors
@sergio-mena sergio-mena mentioned this pull request Feb 10, 2022
Merged
sergio-mena pushed a commit that referenced this pull request Feb 14, 2022
@tac0turtle @sergio-mena
Rebased and git-squashed the commits in PR #6546
92bab80 
migrate abci to finalizeBlock

work on abci, proxy and mempool

abciresponse, blok events, indexer, some tests

fix some tests

fix errors

fix errors in abci

fix tests amd errors
sergio-mena added a commit that referenced this pull request Feb 14, 2022
@sergio-mena @tac0turtle @williambanfield
Completed the existing FinalizeBlock PR and rebased to master (#7798)
d3548eb 
* Rebased and git-squashed the commits in PR #6546

migrate abci to finalizeBlock

work on abci, proxy and mempool

abciresponse, blok events, indexer, some tests

fix some tests

fix errors

fix errors in abci

fix tests amd errors

* Fixes after rebasing PR#6546

* Restored height to RequestFinalizeBlock & other

* Fixed more UTs

* Fixed kvstore

* More UT fixes

* last TC fixed

* make format

* Update internal/consensus/mempool_test.go

Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com>

* Addressed @williambanfield's comments

* Fixed UTs

* Addressed last comments from @williambanfield

* make format

Co-authored-by: marbar3778 <marbar3778@yahoo.com>
Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com>
@williambanfield williambanfield restored the finalizeBlock branch February 25, 2022 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

stale for use by stalebot

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tac0turtle @cmwaters