change the way to stop making empty blocks.#760
Closed
kidinamoto01 wants to merge 1 commit intotendermint:developfrom
kidinamoto01:master
Closed
change the way to stop making empty blocks.#760kidinamoto01 wants to merge 1 commit intotendermint:developfrom kidinamoto01:master
kidinamoto01 wants to merge 1 commit intotendermint:developfrom
kidinamoto01:master
Conversation
Contributor
|
Thanks for this, but unfortunately we can't do it. We need to make empty blocks sometimes to get commits on the apphashes that result from txs. The problem with ethermint is the app hash updates with every block, even without txs, so it will never stop. We need to make a change in ethermint to fix this. |
firelizzard18
pushed a commit
to AccumulateNetwork/tendermint
that referenced
this pull request
Nov 24, 2023
The PR closes issue #25 partially. Changes made: - Bump version v0.37 to v0.38 in docs. - Update docs to remove reference to `BeginBlock`, `EndBlock`, and `DeliverTx` and consolidate them into `FinalizeBlock.` - Minor changes to the formatting of docs. #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [X] Updated relevant documentation (`docs/` or `spec/`) and code comments (cherry picked from commit d31be6b) Co-authored-by: Aliasgar Merchant <44069404+alijnmerchant21@users.noreply.github.com>
firelizzard18
pushed a commit
to AccumulateNetwork/tendermint
that referenced
this pull request
Feb 1, 2024
The PR closes issue #25 partially. Changes made: - Bump version v0.37 to v0.38 in docs. - Update docs to remove reference to `BeginBlock`, `EndBlock`, and `DeliverTx` and consolidate them into `FinalizeBlock.` - Minor changes to the formatting of docs. #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [X] Updated relevant documentation (`docs/` or `spec/`) and code comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hey,
I looked into the problem of enabling no empty block /w Ethermint. EM's AppHash will always change.
I change the way to stop TM making empty blocks calls by also checking mempool.
Cheers