p2p: add Channels to NodeInfo and don't send for unknown channels#1049
Merged
p2p: add Channels to NodeInfo and don't send for unknown channels#1049
Conversation
melekes
reviewed
Jan 6, 2018
p2p/types.go
Outdated
| for _, ch1 := range info.Channels { | ||
| for _, ch2 := range other.Channels { | ||
| if ch1 == ch2 { | ||
| found = true |
node/node.go
Outdated
| cs.StateChannel, cs.DataChannel, cs.VoteChannel, cs.VoteSetBitsChannel, | ||
| mempl.MempoolChannel, | ||
| evidence.EvidenceChannel, | ||
| p2p.PexChannel, |
Contributor
what about this part? |
Merged
984a416 to
0ea750b
Compare
Contributor
Author
|
The old code wasn't actually doing what we wanted. Force pushed the fix. PTAL |
Contributor
Author
This is implemented already since if we receive a msg for an unknown channel we stopPeerForError. |
This was referenced Jan 21, 2018
Closed
Contributor
Author
|
We should add a config option for what channels we require from our peers |
0ea750b to
50129ad
Compare
Contributor
Author
|
Saving that for #1148 |
melekes
reviewed
Jan 24, 2018
p2p/node_info.go
Outdated
| for _, ch2 := range other.Channels { | ||
| if ch1 == ch2 { | ||
| found = true | ||
| break // only need one |
Contributor
There was a problem hiding this comment.
I think the intention here was to break from outer loop, no? maybe break OUTER_LOOP
Codecov Report
@@ Coverage Diff @@
## develop #1049 +/- ##
===========================================
+ Coverage 59.39% 59.39% +<.01%
===========================================
Files 121 121
Lines 10993 11022 +29
===========================================
+ Hits 6529 6547 +18
- Misses 3860 3866 +6
- Partials 604 609 +5 |
firelizzard18
pushed a commit
to AccumulateNetwork/tendermint
that referenced
this pull request
Nov 24, 2023
The PR closes issue #25 partially. Changes made: - Bump version v0.37 to v0.38 in docs. - Update docs to remove reference to `BeginBlock`, `EndBlock`, and `DeliverTx` and consolidate them into `FinalizeBlock.` - Minor changes to the formatting of docs. #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [X] Updated relevant documentation (`docs/` or `spec/`) and code comments (cherry picked from commit d31be6b) Co-authored-by: Aliasgar Merchant <44069404+alijnmerchant21@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #957