test: don't use foo-bar.net in TestHTTPClientMakeHTTPDialer#5997
Merged
mergify[bot] merged 2 commits intomasterfrom Jan 27, 2021
Merged
test: don't use foo-bar.net in TestHTTPClientMakeHTTPDialer#5997mergify[bot] merged 2 commits intomasterfrom
mergify[bot] merged 2 commits intomasterfrom
Conversation
alexanderbez
approved these changes
Jan 27, 2021
Contributor
|
|
5 tasks
cmwaters
pushed a commit
that referenced
this pull request
Feb 4, 2021
This test relied on connecting to the external site `foo-bar.net`, and (predictably) the site went down and broke all of our CI runs. This changes it to use local HTTP servers instead.
melekes
pushed a commit
that referenced
this pull request
Feb 4, 2021
…6047) This test relied on connecting to the external site `foo-bar.net`, and (predictably) the site went down and broke all of our CI runs. This changes it to use local HTTP servers instead. Co-authored-by: Erik Grinaker <erik@interchain.berlin>
melekes
pushed a commit
that referenced
this pull request
Feb 9, 2021
This test relied on connecting to the external site `foo-bar.net`, and (predictably) the site went down and broke all of our CI runs. This changes it to use local HTTP servers instead.
cmwaters
pushed a commit
that referenced
this pull request
Feb 11, 2021
This test relied on connecting to the external site `foo-bar.net`, and (predictably) the site went down and broke all of our CI runs. This changes it to use local HTTP servers instead.
This was referenced Apr 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test relied on connecting to the external site
foo-bar.net, and (predictably) the site went down and broke all of our CI runs. This changes it to use local HTTP servers instead.