tests: backport TestHTTPClientMakeHTTPDialer fix#6047
Merged
Conversation
This test relied on connecting to the external site `foo-bar.net`, and (predictably) the site went down and broke all of our CI runs. This changes it to use local HTTP servers instead.
Codecov Report
@@ Coverage Diff @@
## v0.34.x #6047 +/- ##
==========================================
Coverage ? 60.48%
==========================================
Files ? 263
Lines ? 23855
Branches ? 0
==========================================
Hits ? 14429
Misses ? 7944
Partials ? 1482 |
melekes
approved these changes
Feb 4, 2021
This was referenced Apr 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Erik's PR:
Are their any other tests we should backport to
v0.34.x?