Skip to content

p2p: fix MConnection inbound traffic statistics and rate limiting#5868

Merged
erikgrinaker merged 5 commits intomasterfrom
erik/protoio-read-count
Jan 6, 2021
Merged

p2p: fix MConnection inbound traffic statistics and rate limiting#5868
erikgrinaker merged 5 commits intomasterfrom
erik/protoio-read-count

Conversation

@erikgrinaker
Copy link
Contributor

@erikgrinaker erikgrinaker commented Jan 6, 2021

Fixes #5866. Inbound traffic monitoring (and by extension inbound rate limiting) was inadvertently removed in 660e72a.

@erikgrinaker erikgrinaker self-assigned this Jan 6, 2021
@codecov
Copy link

codecov bot commented Jan 6, 2021 •
edited
Loading

Codecov Report

Merging #5868 (29182c0) into master (9b9222f) will increase coverage by 0.05%.
The diff coverage is 88.23%.

@@            Coverage Diff             @@
##           master    #5868      +/-   ##
==========================================
+ Coverage   59.98%   60.03%   +0.05%     
==========================================
  Files         263      263              
  Lines       23858    23868      +10     
==========================================
+ Hits        14312    14330      +18     
+ Misses       8021     8015       -6     
+ Partials     1525     1523       -2
Impacted Files Coverage Δ
libs/protoio/reader.go 85.18% <76.47%> (+0.18%) ⬆️
abci/types/messages.go 7.69% <100.00%> (ø)
libs/protoio/io.go 44.44% <100.00%> (+3.26%) ⬆️
p2p/conn/connection.go 78.78% <100.00%> (+0.61%) ⬆️
p2p/conn/secret_connection.go 82.98% <100.00%> (ø)
p2p/transport_mconn.go 42.01% <100.00%> (+0.18%) ⬆️
privval/secret_connection.go 72.68% <100.00%> (-3.61%) ⬇️
privval/signer_endpoint.go 78.78% <100.00%> (ø)
privval/signer_listener_endpoint.go 82.35% <0.00%> (-7.06%) ⬇️
privval/socket_listeners.go 78.72% <0.00%> (-4.26%) ⬇️
... and 13 more

@erikgrinaker erikgrinaker marked this pull request as ready for review January 6, 2021 14:17
@erikgrinaker erikgrinaker changed the title p2p: fix MConnection inbound traffic monitoring p2p: fix MConnection inbound traffic monitoring and rate limiting Jan 6, 2021
@erikgrinaker erikgrinaker changed the title p2p: fix MConnection inbound traffic monitoring and rate limiting p2p: fix MConnection inbound traffic statistics and rate limiting Jan 6, 2021
@erikgrinaker erikgrinaker merged commit 1ccd23c into master Jan 6, 2021
@erikgrinaker erikgrinaker deleted the erik/protoio-read-count branch January 6, 2021 14:38
erikgrinaker added a commit that referenced this pull request Jan 6, 2021
@erikgrinaker
p2p: fix MConnection inbound traffic statistics and rate limiting (#5868
500c3a3 
)

Fixes #5866. Inbound traffic monitoring (and by extension inbound rate limiting) was inadvertently removed in 660e72a.
erikgrinaker added a commit that referenced this pull request Jan 6, 2021
@erikgrinaker
p2p: fix MConnection inbound traffic statistics and rate limiting (#5868
d1cbc4e 
)

Fixes #5866. Inbound traffic monitoring (and by extension inbound rate limiting) was inadvertently removed in 660e72a.
@erikgrinaker erikgrinaker mentioned this pull request Jan 6, 2021
Merged
tessr pushed a commit that referenced this pull request Jan 6, 2021
@erikgrinaker
p2p: fix MConnection inbound traffic statistics and rate limiting (#5868
13833cb 
) (#5870)

Fixes #5866. Inbound traffic monitoring (and by extension inbound rate limiting) was inadvertently removed in 660e72a.
@erikgrinaker erikgrinaker mentioned this pull request Jan 6, 2021
Merged
@cmwaters cmwaters mentioned this pull request Feb 22, 2022
Merged
This was referenced Apr 22, 2022
Merged
Merged
thanethomson added a commit that referenced this pull request Aug 6, 2022
@thanethomson
Import ReadMsg interface change from #5868
f605f12 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
thanethomson added a commit that referenced this pull request Aug 6, 2022
@thanethomson
Import ReadMsg interface change from #5868
23e08c9 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
thanethomson added a commit that referenced this pull request Aug 8, 2022
@thanethomson
Import ReadMsg interface change from #5868
c3154bf 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
thanethomson added a commit that referenced this pull request Aug 9, 2022
@thanethomson
Import ReadMsg interface change from #5868
fbd89f7 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
thanethomson added a commit that referenced this pull request Aug 9, 2022
@thanethomson
Import ReadMsg interface change from #5868
337bbe3 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
thanethomson added a commit that referenced this pull request Aug 11, 2022
@thanethomson
Import ReadMsg interface change from #5868
a11bae7 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
thanethomson added a commit that referenced this pull request Aug 11, 2022
@thanethomson @tac0turtle
abci: Make ABCI and P2P wire-level length delimiters consistent (#9182)
ae1fc74 
* abci: use protoio for length delimitation (#5818)

Migrate ABCI to use protoio (uint64 length delimiters) instead of int64
length delimiters to be consistent with the approach used in the P2P
layer.

Closes: #5783

* Import ReadMsg interface change from #5868

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Convert PR number to link in UPGRADING

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Update Tendermint Socket Protocol docs to reflect length prefix encoding change

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Clarify that length delimiters are varints

Signed-off-by: Thane Thomson <connect@thanethomson.com>

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
samricotta pushed a commit that referenced this pull request Aug 12, 2022
@thanethomson @tac0turtle @samricotta
abci: Make ABCI and P2P wire-level length delimiters consistent (#9182)
5f88d88 
* abci: use protoio for length delimitation (#5818)

Migrate ABCI to use protoio (uint64 length delimiters) instead of int64
length delimiters to be consistent with the approach used in the P2P
layer.

Closes: #5783

* Import ReadMsg interface change from #5868

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Convert PR number to link in UPGRADING

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Update Tendermint Socket Protocol docs to reflect length prefix encoding change

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Clarify that length delimiters are varints

Signed-off-by: Thane Thomson <connect@thanethomson.com>

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
samricotta pushed a commit that referenced this pull request Aug 12, 2022
@thanethomson @tac0turtle @samricotta
abci: Make ABCI and P2P wire-level length delimiters consistent (#9182)
c1ac294 
* abci: use protoio for length delimitation (#5818)

Migrate ABCI to use protoio (uint64 length delimiters) instead of int64
length delimiters to be consistent with the approach used in the P2P
layer.

Closes: #5783

* Import ReadMsg interface change from #5868

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Convert PR number to link in UPGRADING

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Update Tendermint Socket Protocol docs to reflect length prefix encoding change

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Clarify that length delimiters are varints

Signed-off-by: Thane Thomson <connect@thanethomson.com>

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
samricotta pushed a commit that referenced this pull request Aug 16, 2022
@thanethomson @tac0turtle @samricotta
abci: Make ABCI and P2P wire-level length delimiters consistent (#9182)
25e3169 
* abci: use protoio for length delimitation (#5818)

Migrate ABCI to use protoio (uint64 length delimiters) instead of int64
length delimiters to be consistent with the approach used in the P2P
layer.

Closes: #5783

* Import ReadMsg interface change from #5868

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Convert PR number to link in UPGRADING

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Update Tendermint Socket Protocol docs to reflect length prefix encoding change

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Clarify that length delimiters are varints

Signed-off-by: Thane Thomson <connect@thanethomson.com>

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ebuchman ebuchman Awaiting requested review from ebuchman

@tac0turtle tac0turtle Awaiting requested review from tac0turtle

@melekes melekes Awaiting requested review from melekes

@tessr tessr Awaiting requested review from tessr

1 more reviewer

@alexanderbez alexanderbez alexanderbez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@erikgrinaker erikgrinaker

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

p2p/conn/connection.go recvMonitor.Update() is not called

2 participants

@erikgrinaker @alexanderbez