Skip to content

abci: use protoio for length delimitation#5818

Merged
tac0turtle merged 6 commits intomasterfrom
marko/5783_abci-encoding
Dec 21, 2020
Merged

abci: use protoio for length delimitation#5818
tac0turtle merged 6 commits intomasterfrom
marko/5783_abci-encoding

Conversation

@tac0turtle
Copy link
Contributor

@tac0turtle tac0turtle commented Dec 21, 2020

Description

Migrate ABCI to use protoio (uint64 length delimitation) instead of specific int64 length delimiters.

Closes: #5783

@tac0turtle tac0turtle added C:abci Component: Application Blockchain Interface T:breaking Type: Breaking Change labels Dec 21, 2020
@tac0turtle tac0turtle self-assigned this Dec 21, 2020
@codecov
Copy link

codecov bot commented Dec 21, 2020 •
edited
Loading

Codecov Report

Merging #5818 (91f2938) into master (0a41711) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5818      +/-   ##
==========================================
+ Coverage   59.90%   59.92%   +0.02%     
==========================================
  Files         262      262              
  Lines       23688    23668      -20     
==========================================
- Hits        14190    14183       -7     
+ Misses       7991     7984       -7     
+ Partials     1507     1501       -6
Impacted Files Coverage Δ
abci/types/messages.go 7.69% <100.00%> (-12.31%) ⬇️
types/tx.go 82.97% <0.00%> (-4.26%) ⬇️
statesync/snapshots.go 91.59% <0.00%> (-1.69%) ⬇️
blockchain/v0/pool.go 79.84% <0.00%> (-1.53%) ⬇️
blockchain/v2/reactor.go 32.73% <0.00%> (-1.44%) ⬇️
blockchain/v0/reactor.go 63.06% <0.00%> (-0.91%) ⬇️
p2p/switch.go 65.37% <0.00%> (-0.60%) ⬇️
consensus/state.go 68.21% <0.00%> (-0.19%) ⬇️
proxy/multi_app_conn.go 48.05% <0.00%> (ø)
p2p/pex/pex_reactor.go 79.46% <0.00%> (+0.59%) ⬆️
... and 5 more

@tac0turtle tac0turtle marked this pull request as ready for review December 21, 2020 15:34
@tac0turtle tac0turtle requested a review from cmwaters December 21, 2020 15:34
melekes
melekes approved these changes Dec 21, 2020
View reviewed changes
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@tac0turtle tac0turtle merged commit 886442c into master Dec 21, 2020
@tac0turtle tac0turtle deleted the marko/5783_abci-encoding branch December 21, 2020 16:51
cmwaters pushed a commit that referenced this pull request Jan 4, 2021
@tac0turtle @cmwaters
abci: use protoio for length delimitation (#5818)
bf55fe3 
Migrate ABCI to use protoio (uint64 length delimitation) instead of specific int64 length delimiters.

Closes: #5783
This was referenced Aug 5, 2022
Closed
Closed
thanethomson pushed a commit that referenced this pull request Aug 6, 2022
@tac0turtle @thanethomson
abci: use protoio for length delimitation (#5818)
f4563c5 
Migrate ABCI to use protoio (uint64 length delimiters) instead of int64
length delimiters to be consistent with the approach used in the P2P
layer.

Closes: #5783
thanethomson pushed a commit that referenced this pull request Aug 6, 2022
@tac0turtle @thanethomson
abci: use protoio for length delimitation (#5818)
9e8474b 
Migrate ABCI to use protoio (uint64 length delimiters) instead of int64
length delimiters to be consistent with the approach used in the P2P
layer.

Closes: #5783
thanethomson pushed a commit that referenced this pull request Aug 8, 2022
@tac0turtle @thanethomson
abci: use protoio for length delimitation (#5818)
78132b5 
Migrate ABCI to use protoio (uint64 length delimiters) instead of int64
length delimiters to be consistent with the approach used in the P2P
layer.

Closes: #5783
thanethomson pushed a commit that referenced this pull request Aug 9, 2022
@tac0turtle @thanethomson
abci: use protoio for length delimitation (#5818)
daf345d 
Migrate ABCI to use protoio (uint64 length delimiters) instead of int64
length delimiters to be consistent with the approach used in the P2P
layer.

Closes: #5783
thanethomson pushed a commit that referenced this pull request Aug 9, 2022
@tac0turtle @thanethomson
abci: use protoio for length delimitation (#5818)
c1a2e47 
Migrate ABCI to use protoio (uint64 length delimiters) instead of int64
length delimiters to be consistent with the approach used in the P2P
layer.

Closes: #5783
thanethomson pushed a commit that referenced this pull request Aug 11, 2022
@tac0turtle @thanethomson
abci: use protoio for length delimitation (#5818)
65c8ff7 
Migrate ABCI to use protoio (uint64 length delimiters) instead of int64
length delimiters to be consistent with the approach used in the P2P
layer.

Closes: #5783
thanethomson added a commit that referenced this pull request Aug 11, 2022
@thanethomson @tac0turtle
abci: Make ABCI and P2P wire-level length delimiters consistent (#9182)
ae1fc74 
* abci: use protoio for length delimitation (#5818)

Migrate ABCI to use protoio (uint64 length delimiters) instead of int64
length delimiters to be consistent with the approach used in the P2P
layer.

Closes: #5783

* Import ReadMsg interface change from #5868

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Convert PR number to link in UPGRADING

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Update Tendermint Socket Protocol docs to reflect length prefix encoding change

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Clarify that length delimiters are varints

Signed-off-by: Thane Thomson <connect@thanethomson.com>

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
samricotta pushed a commit that referenced this pull request Aug 12, 2022
@thanethomson @tac0turtle @samricotta
abci: Make ABCI and P2P wire-level length delimiters consistent (#9182)
5f88d88 
* abci: use protoio for length delimitation (#5818)

Migrate ABCI to use protoio (uint64 length delimiters) instead of int64
length delimiters to be consistent with the approach used in the P2P
layer.

Closes: #5783

* Import ReadMsg interface change from #5868

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Convert PR number to link in UPGRADING

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Update Tendermint Socket Protocol docs to reflect length prefix encoding change

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Clarify that length delimiters are varints

Signed-off-by: Thane Thomson <connect@thanethomson.com>

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
samricotta pushed a commit that referenced this pull request Aug 12, 2022
@thanethomson @tac0turtle @samricotta
abci: Make ABCI and P2P wire-level length delimiters consistent (#9182)
c1ac294 
* abci: use protoio for length delimitation (#5818)

Migrate ABCI to use protoio (uint64 length delimiters) instead of int64
length delimiters to be consistent with the approach used in the P2P
layer.

Closes: #5783

* Import ReadMsg interface change from #5868

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Convert PR number to link in UPGRADING

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Update Tendermint Socket Protocol docs to reflect length prefix encoding change

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Clarify that length delimiters are varints

Signed-off-by: Thane Thomson <connect@thanethomson.com>

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
samricotta pushed a commit that referenced this pull request Aug 16, 2022
@thanethomson @tac0turtle @samricotta
abci: Make ABCI and P2P wire-level length delimiters consistent (#9182)
25e3169 
* abci: use protoio for length delimitation (#5818)

Migrate ABCI to use protoio (uint64 length delimiters) instead of int64
length delimiters to be consistent with the approach used in the P2P
layer.

Closes: #5783

* Import ReadMsg interface change from #5868

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Convert PR number to link in UPGRADING

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Update Tendermint Socket Protocol docs to reflect length prefix encoding change

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Clarify that length delimiters are varints

Signed-off-by: Thane Thomson <connect@thanethomson.com>

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ebuchman ebuchman Awaiting requested review from ebuchman

@erikgrinaker erikgrinaker Awaiting requested review from erikgrinaker

@tessr tessr Awaiting requested review from tessr

@cmwaters cmwaters Awaiting requested review from cmwaters

1 more reviewer

@melekes melekes melekes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tac0turtle tac0turtle

Labels

C:abci Component: Application Blockchain Interface T:breaking Type: Breaking Change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

protobuf/abci/p2p: Length delimiter encoding differs between ABCI and P2P

2 participants

@tac0turtle @melekes