Merged
Conversation
57c2b22 to
287245e
Compare
Codecov Report
@@ Coverage Diff @@
## master #5447 +/- ##
=========================================
Coverage ? 61.48%
=========================================
Files ? 259
Lines ? 23426
Branches ? 0
=========================================
Hits ? 14403
Misses ? 7565
Partials ? 1458
|
melekes
approved these changes
Oct 4, 2020
Contributor
|
Is there a PR which updates the spec? |
tac0turtle
commented
Oct 6, 2020
since there's no serial option, counter app always returns OK (even if transactions are not in serial order)
tac0turtle
commented
Oct 7, 2020
| } | ||
| } | ||
|
|
||
| /*func checkTx(client abcicli.Client, txBytes []byte, codeExp uint32, dataExp []byte) { |
Contributor
Author
There was a problem hiding this comment.
dam, whats your take on the possibility of removing counter app and just supporting kvstore? It seems counter does not provide anything extra?
melekes
added a commit
that referenced
this pull request
Oct 9, 2020
Remove Response/Request SetOption from ABCI. Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
remove Response/Request SetOption from ABCI.
I couldn't find it being used anywhere.
Closes: #XXX