abci: Remove SetOption #5447 #9091#9266
Merged
samricotta merged 7 commits intofeature/abci++pppfrom Aug 16, 2022
Merged
Conversation
b48fd30 to
7bd6991
Compare
7bd6991 to
5a40ba7
Compare
cmwaters
approved these changes
Aug 16, 2022
tychoish
approved these changes
Aug 16, 2022
Contributor
tychoish
left a comment
There was a problem hiding this comment.
change logs should be good.
I think this is pretty unobjectionable and since this isn't used and we're already breaking abci a bit for this, it's fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving the changes from issue #5447 into main. This PR removes theResponse/Request SetOption from ABCI replicated from #5447
Note: This is part of the ABCI++ Prepare/Process Proposal Release Plan #9091