Skip to content

docs: add more details on Vote struct from /consensus_state#5164

Merged
mergify[bot] merged 1 commit intomasterfrom
anton/2743-vote
Jul 29, 2020
Merged

docs: add more details on Vote struct from /consensus_state#5164
mergify[bot] merged 1 commit intomasterfrom
anton/2743-vote

Conversation

@melekes
Copy link
Contributor

@melekes melekes commented Jul 29, 2020

Closes #2743

@melekes melekes requested a review from tessr as a code owner July 29, 2020 08:11
@auto-comment
Copy link

auto-comment bot commented Jul 29, 2020

👋 Thanks for creating a PR!

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Wrote tests
  • Updated CHANGELOG_PENDING.md
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments
  • Re-reviewed Files changed in the Github PR explorer
  • Applied Appropriate Labels

Thank you for your contribution to Tendermint! 🚀

@melekes melekes self-assigned this Jul 29, 2020
@melekes melekes added S:automerge Automatically merge PR when requirements pass C:docs Component: Documentation labels Jul 29, 2020
@codecov
Copy link

codecov bot commented Jul 29, 2020 •
edited
Loading

Codecov Report

Merging #5164 into master will increase coverage by 1.62%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5164      +/-   ##
==========================================
+ Coverage   61.03%   62.66%   +1.62%     
==========================================
  Files         203      259      +56     
  Lines       20538    27279    +6741     
==========================================
+ Hits        12536    17095    +4559     
- Misses       6926     8706    +1780     
- Partials     1076     1478     +402
Impacted Files Coverage Δ
types/part_set.go 71.82% <ø> (ø)
types/proposal.go 91.04% <ø> (ø)
types/validator.go 81.91% <ø> (ø)
types/validator_set.go 87.84% <ø> (ø)
types/vote.go 89.09% <ø> (ø)
types/vote_set.go 47.61% <ø> (ø)
types/block.go 71.97% <100.00%> (ø)
blockchain/v0/pool.go 79.29% <0.00%> (-1.28%) ⬇️
consensus/replay.go 72.57% <0.00%> (-0.85%) ⬇️
statesync/syncer.go 79.44% <0.00%> (-0.80%) ⬇️
... and 61 more

tac0turtle
tac0turtle reviewed Jul 29, 2020
View reviewed changes
@mergify mergify bot merged commit 4ab7b7d into master Jul 29, 2020
@mergify mergify bot deleted the anton/2743-vote branch July 29, 2020 10:20
iKapitonau pushed a commit to scrtlabs/tendermint that referenced this pull request Oct 16, 2025
@mergify
chore: fix typo in workflow_dispatch (backport tendermint#5164) (tend…
305bdcf 
…ermint#5166)

---

#### PR checklist

- [x] Tests written/updated
- [x] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [x] Updated relevant documentation (`docs/` or `spec/`) and code
comments
<hr>This is an automatic backport of pull request tendermint#5164 done by
[Mergify](https://mergify.com).

---------

Co-authored-by: Zachary Becker <zachary@interchainlabs.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tessr tessr Awaiting requested review from tessr

1 more reviewer

@tac0turtle tac0turtle tac0turtle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@melekes melekes

Labels

C:docs Component: Documentation S:automerge Automatically merge PR when requirements pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add more details on Vote struct from /consensus_state to documentation

2 participants

@melekes @tac0turtle