Conversation
melekes
suggested changes
Feb 23, 2017
cmd/tendermint/commands/replay.go
Outdated
| ) | ||
|
|
||
| var replayCmd = &cobra.Command{ | ||
| Use: "replay", |
cmd/tendermint/commands/replay.go
Outdated
| } | ||
|
|
||
| var replayConsoleCmd = &cobra.Command{ | ||
| Use: "replay_console", |
cmd/tendermint/commands/root.go
Outdated
| // parse flags | ||
|
|
||
| // configuration options | ||
| RootCmd.PersistentFlags().StringVar(&moniker, "moniker", config.GetString("moniker"), "Node Name") |
Contributor
There was a problem hiding this comment.
Correct me if I am wrong, but all these flags belong to runNodeCmd and should be moved there. Except maybe log_level. Can we do that?
melekes
reviewed
Feb 23, 2017
cmd/tendermint/commands/run_node.go
Outdated
|
|
||
| //flags | ||
| var ( | ||
| printHelp bool |
50a10a0 to
ec29ca5
Compare
Codecov Report
@@ Coverage Diff @@
## develop #419 +/- ##
=========================================
- Coverage 52.37% 52% -0.37%
=========================================
Files 44 44
Lines 4926 4926
=========================================
- Hits 2580 2562 -18
- Misses 2130 2142 +12
- Partials 216 222 +6Continue to review full report at Codecov.
|
melekes
approved these changes
Feb 24, 2017
Contributor
Author
|
Add use of Viper to replace config as a part of this PR? |
Contributor
|
I think the go-config -> viper should be a separate pull request. Cobra alone cleans up the cli. Changing the config file, doesn't just involve changing the cli, it means changing every call to It's a big piece of work. Maybe get cobra/viper in basecoin first, then go for viper in tendermint core. |
Contributor
|
P.S. It looks like you need to rebase on develop again... |
Contributor
Author
|
Thanks Frey, I will make a separate PR off of cli_cobra branch |
b687d63 to
c9acae8
Compare
melekes
reviewed
Mar 27, 2017
glide.yaml
Outdated
| @@ -1,4 +1,4 @@ | |||
| package: github.com/tendermint/tendermint | |||
| eackage: github.com/tendermint/tendermint | |||
Closed
faddat
referenced
this pull request
in notional-labs/tendermint
Apr 3, 2023
As of #419, we now use Go 1.20 on the `v0.37.x` branch. This is already up-to-date on the `v0.37.x` branch itself: https://github.com/cometbft/cometbft/tree/v0.37.x#minimum-requirements --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments
adrianbrink
pushed a commit
to heliaxdev/tendermint
that referenced
this pull request
May 23, 2023
* Update to use Go 1.20 (tendermint#405) * Bump minimum Go version to 1.20 in go.mod Signed-off-by: Thane Thomson <connect@thanethomson.com> * Bump minimum Go version in CI/test infra Signed-off-by: Thane Thomson <connect@thanethomson.com> * Bump Go version in docs Signed-off-by: Thane Thomson <connect@thanethomson.com> * Add changelog entry Signed-off-by: Thane Thomson <connect@thanethomson.com> * Ignore lint Signed-off-by: Thane Thomson <connect@thanethomson.com> * Fix math/rand usages in tests Signed-off-by: Thane Thomson <connect@thanethomson.com> * Fix lint: use local random source in test Signed-off-by: Thane Thomson <connect@thanethomson.com> * Rename variable for clarity Signed-off-by: Thane Thomson <connect@thanethomson.com> * ci: Bump version of golangci-lint to latest Signed-off-by: Thane Thomson <connect@thanethomson.com> --------- Signed-off-by: Thane Thomson <connect@thanethomson.com> (cherry picked from commit 200784a) # Conflicts: # .github/workflows/e2e-nightly-37x.yml # README.md # libs/rand/random.go # test/fuzz/README.md # test/fuzz/p2p/secret_connection/read_write.go # test/fuzz/tests/mempool_test.go # test/fuzz/tests/rpc_jsonrpc_server_test.go * Resolve conflicts Signed-off-by: Thane Thomson <connect@thanethomson.com> * Remove use of deprecated global random seed Signed-off-by: Thane Thomson <connect@thanethomson.com> * Attempt to appease linter Signed-off-by: Thane Thomson <connect@thanethomson.com> * Attempt 2 to appease linter Signed-off-by: Thane Thomson <connect@thanethomson.com> --------- Signed-off-by: Thane Thomson <connect@thanethomson.com> Co-authored-by: Thane Thomson <connect@thanethomson.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #312
replaced internal CLI system with Cobra