Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #405 +/- ##
===========================================
- Coverage 51.62% 51.46% -0.17%
===========================================
Files 37 37
Lines 4453 4452 -1
===========================================
- Hits 2299 2291 -8
- Misses 1940 1948 +8
+ Partials 214 213 -1Continue to review full report at Codecov.
|
melekes
approved these changes
Feb 15, 2017
Contributor
|
Cool. Nice job with the commits from current block. Maybe we could send this along with the header as I suggest in #407 type ResultCommit struct {
*Header `json:"header"`
*Commit `json:"commit"`
Canonical bool `json:"canonical"`
}What do you think? It would make me happy ;) |
Contributor
Author
|
Isn't that what it already does? What am I missing? |
Contributor
|
I just looked at the diff for the "added /commit" commit. I didn't see you added the Header in a later field. yes, I like it. and if it makes in by 0.9 even more awesome! |
faddat
referenced
this pull request
in notional-labs/tendermint
Apr 3, 2023
* Bump minimum Go version to 1.20 in go.mod Signed-off-by: Thane Thomson <connect@thanethomson.com> * Bump minimum Go version in CI/test infra Signed-off-by: Thane Thomson <connect@thanethomson.com> * Bump Go version in docs Signed-off-by: Thane Thomson <connect@thanethomson.com> * Add changelog entry Signed-off-by: Thane Thomson <connect@thanethomson.com> * Ignore lint Signed-off-by: Thane Thomson <connect@thanethomson.com> * Fix math/rand usages in tests Signed-off-by: Thane Thomson <connect@thanethomson.com> * Fix lint: use local random source in test Signed-off-by: Thane Thomson <connect@thanethomson.com> * Rename variable for clarity Signed-off-by: Thane Thomson <connect@thanethomson.com> * ci: Bump version of golangci-lint to latest Signed-off-by: Thane Thomson <connect@thanethomson.com> --------- Signed-off-by: Thane Thomson <connect@thanethomson.com>
adrianbrink
pushed a commit
to heliaxdev/tendermint
that referenced
this pull request
May 23, 2023
* Update to use Go 1.20 (tendermint#405) * Bump minimum Go version to 1.20 in go.mod Signed-off-by: Thane Thomson <connect@thanethomson.com> * Bump minimum Go version in CI/test infra Signed-off-by: Thane Thomson <connect@thanethomson.com> * Bump Go version in docs Signed-off-by: Thane Thomson <connect@thanethomson.com> * Add changelog entry Signed-off-by: Thane Thomson <connect@thanethomson.com> * Ignore lint Signed-off-by: Thane Thomson <connect@thanethomson.com> * Fix math/rand usages in tests Signed-off-by: Thane Thomson <connect@thanethomson.com> * Fix lint: use local random source in test Signed-off-by: Thane Thomson <connect@thanethomson.com> * Rename variable for clarity Signed-off-by: Thane Thomson <connect@thanethomson.com> * ci: Bump version of golangci-lint to latest Signed-off-by: Thane Thomson <connect@thanethomson.com> --------- Signed-off-by: Thane Thomson <connect@thanethomson.com> (cherry picked from commit 200784a) # Conflicts: # .github/workflows/e2e-nightly-37x.yml # README.md # libs/rand/random.go # test/fuzz/README.md # test/fuzz/p2p/secret_connection/read_write.go # test/fuzz/tests/mempool_test.go # test/fuzz/tests/rpc_jsonrpc_server_test.go * Resolve conflicts Signed-off-by: Thane Thomson <connect@thanethomson.com> * Remove use of deprecated global random seed Signed-off-by: Thane Thomson <connect@thanethomson.com> * Attempt to appease linter Signed-off-by: Thane Thomson <connect@thanethomson.com> * Attempt 2 to appease linter Signed-off-by: Thane Thomson <connect@thanethomson.com> --------- Signed-off-by: Thane Thomson <connect@thanethomson.com> Co-authored-by: Thane Thomson <connect@thanethomson.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/committhat returns the header and commit for a block at height HQuestion: should the commit also return the BlockID (ie. the block hash and partsetheader - the former it can get from the header, the latter it can only get from the next block, or by fetching the whole block and building the part set) ?