p2p: extract ID validation into a separate func#3754
Merged
Conversation
golangcibot
reviewed
Jun 26, 2019
452a27b to
16d4347
Compare
- NewNetAddress panics if ID is invalid - NetAddress#Valid returns an error - remove ErrAddrBookInvalidAddrNoID Fixes #2722
16d4347 to
37accc6
Compare
golangcibot
reviewed
Jun 26, 2019
95c5f48 to
327c565
Compare
Codecov Report
@@ Coverage Diff @@
## master #3754 +/- ##
==========================================
- Coverage 64.07% 64.06% -0.01%
==========================================
Files 216 216
Lines 18096 18051 -45
==========================================
- Hits 11595 11565 -30
+ Misses 5524 5508 -16
- Partials 977 978 +1
|
melekes
commented
Jun 26, 2019
| if err != nil || len(data) != IDByteLength { | ||
| return false | ||
| } | ||
| func (na *NetAddress) Valid() error { |
Contributor
Author
There was a problem hiding this comment.
the fact that NetAddress can be invalid bothers me deeply... I think we should refactor the code so NetAddress is always correct. For that we'll need to change NewNetAddressX funcs to return an error + make NewNetAddressIPPort private. Thoughts?
Contributor
There was a problem hiding this comment.
I do agree that it should always be correct, but a validity check is always good. Should we open an issue and quickly discuss there, with others then move forward? or would you like to include those changes here?
Contributor
Author
|
TestStartNextHeightCorrectly has failed: |
tac0turtle
approved these changes
Jul 3, 2019
Contributor
There was a problem hiding this comment.
utACK 👍 just one question, not related to the code but your comment @melekes
| if err != nil || len(data) != IDByteLength { | ||
| return false | ||
| } | ||
| func (na *NetAddress) Valid() error { |
Contributor
There was a problem hiding this comment.
I do agree that it should always be correct, but a validity check is always good. Should we open an issue and quickly discuss there, with others then move forward? or would you like to include those changes here?
| } | ||
| func (na *NetAddress) Valid() error { | ||
| if err := validateID(na.ID); err != nil { | ||
| return errors.Wrap(err, "invalid ID") |
ValarDragon
approved these changes
Jul 8, 2019
Contributor
ValarDragon
left a comment
There was a problem hiding this comment.
Nice improvement!
Agreed with it being better to make the type correct by construction though.
cboh4
pushed a commit
to scrtlabs/tendermint
that referenced
this pull request
Apr 7, 2025
Author: [AlexsandroRyan](https://github.com/AlexsandroRyan) This pull request addresses all CVEs reported by the Checkmarx tool during its execution on this repository. The previous discussion can be found here: https://github.com/cometbft/cometbft/discussions/3558. I have updated all necessary dependencies to fix the identified CVEs, but some vulnerabilities remain unresolved. I would appreciate any assistance in addressing these remaining issues. 1. CVE-2021-3538: This issue is related to the github.com/satori/go.uuid package, which is a dependency of [tm-load-test](https://github.com/informalsystems/tm-load-test). We have already submitted a PR to address this: informalsystems/tm-load-test#221. 2. CVE-2024-24786: This vulnerability pertains to the google.golang.org/protobuf package. Running go mod graph | grep google.golang.org/protobuf reveals that many packages are using the vulnerable version. It’s unclear if updating them individually is feasible. 3. CVE-2024-34478: This vulnerability is associated with github.com/btcsuite/btcd, a dependency of github.com/btcsuite/btcd/btcutil, which is currently used at a version lower than 0.24.0. We have also submitted a pull request for this: btcsuite/btcd#2235. Please let us know if this approach is sufficient or if there is a more efficient way to resolve these issues. <!-- Please add a reference to the issue that this PR addresses and indicate which files are most critical to review. If it fully addresses a particular issue, please include "Closes #XXX" (where "XXX" is the issue number). If this PR is non-trivial/large/complex, please ensure that you have either created an issue that the team's had a chance to respond to, or had some discussion with the team prior to submitting substantial pull requests. The team can be reached via GitHub Discussions or the Cosmos Network Discord server in the #cometbft channel. GitHub Discussions is preferred over Discord as it allows us to keep track of conversations topically. https://github.com/cometbft/cometbft/discussions If the work in this PR is not aligned with the team's current priorities, please be advised that it may take some time before it is merged - especially if it has not yet been discussed with the team. See the project board for the team's current priorities: https://github.com/orgs/cometbft/projects/1 --> --- #### PR checklist - [ ] ~Tests written/updated~ - [ ] ~Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog)~ - [ ] ~Updated relevant documentation (`docs/` or `spec/`) and code comments~ - [ ] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec --------- Co-authored-by: Alexsandro <alexsandrocosta855@gmail.com> Co-authored-by: Alessandro <alessandro@informal.systems>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2722
Updated all relevant documentation in docsWrote testsUpdated CHANGELOG_PENDING.md