abci: Refactor CheckTx to notify of recheck#3744
Merged
Conversation
As per #2127, this refactors the `RequestCheckTx` ProtoBuf struct to allow for: 1. a flag indicating whether a query is a recheck or not (and allows for possible future, more nuanced states) 2. an `additional_data` bytes array to provide information for those more nuanced states. In order to pass this extended information through to the ABCI app, the `proxy.AppConnMempool` (and, for consistency, the `proxy.AppConnConsensus`) interface seems to need to be refactored.
golangcibot
reviewed
Jun 21, 2019
Codecov Report
@@ Coverage Diff @@
## master #3744 +/- ##
==========================================
- Coverage 63.88% 63.82% -0.06%
==========================================
Files 217 217
Lines 18071 18124 +53
==========================================
+ Hits 11545 11568 +23
- Misses 5553 5575 +22
- Partials 973 981 +8
|
thanethomson
commented
Jun 22, 2019
thanethomson
commented
Jun 22, 2019
melekes
reviewed
Jun 24, 2019
melekes
approved these changes
Jun 24, 2019
ValarDragon
approved these changes
Jul 2, 2019
Contributor
ValarDragon
left a comment
There was a problem hiding this comment.
This is great! Thanks for implementing it!
ebuchman
reviewed
Jul 12, 2019
| - **Request**: | ||
| - `Tx ([]byte)`: The request transaction bytes | ||
| - `Type (CheckTxType)`: What type of `CheckTx` request is this? At present, | ||
| there are two possible values: `CheckTx_Unchecked` (the default, which says |
Contributor
There was a problem hiding this comment.
Oh, seems this is not aligned with the changes actually made to the proto file, ie. the types are New and Recheck
Contributor
There was a problem hiding this comment.
We should actually also add an entry to docs/spec/abci/apps.md explaining the impact of this field on application developers (ie. they may be able to skip signature verification)
| there are two possible values: `CheckTx_Unchecked` (the default, which says | ||
| that a full check is required), and `CheckTx_Checked` (when the mempool is | ||
| initiating a normal recheck of a transaction). | ||
| - `AdditionalData ([]byte)`: Reserved for future use. See |
Contributor
There was a problem hiding this comment.
This wasn't implemented yet
thanethomson
added a commit
that referenced
this pull request
Jul 12, 2019
5 tasks
tac0turtle
pushed a commit
that referenced
this pull request
Jul 12, 2019
* Update ABCI docs to reflect latest changes on PR #3744 * Add note about new Type parameter for CheckTx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #2127, this refactors the
RequestCheckTxProtoBuf struct to allow for a flag indicating whether a query is a recheck or not (and allows for possible future, more nuanced states).In order to pass this extended information through to the ABCI app, the
proxy.AppConnMempool(and, for consistency, theproxy.AppConnConsensus) interface seems to need to be refactored along withabcicli.Client.And, as per this comment, I've made the following modification to the protobuf definition for the
RequestCheckTxstructure: