Skip to content

abci: Fix documentation regarding CheckTx type update#3789

Merged
tac0turtle merged 2 commits intomasterfrom
3744-fix-docs
Jul 12, 2019
Merged

abci: Fix documentation regarding CheckTx type update#3789
tac0turtle merged 2 commits intomasterfrom
3744-fix-docs

Conversation

@thanethomson
Copy link
Contributor

As per comments here and here.

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

Copy link
Contributor

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-io
Copy link

Codecov Report

Merging #3789 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #3789      +/-   ##
=========================================
+ Coverage   64.17%   64.2%   +0.03%     
=========================================
  Files         214     214              
  Lines       18002   18010       +8     
=========================================
+ Hits        11553   11564      +11     
+ Misses       5470    5467       -3     
  Partials      979     979
Impacted Files Coverage Δ
p2p/pex/pex_reactor.go 82.55% <0%> (-2.33%) ⬇️
consensus/replay.go 70.2% <0%> (-1.23%) ⬇️
consensus/state.go 79.97% <0%> (+0.11%) ⬆️
evidence/store.go 92.59% <0%> (+0.81%) ⬆️
consensus/reactor.go 71.62% <0%> (+0.93%) ⬆️
blockchain/pool.go 81.25% <0%> (+1.64%) ⬆️

@tac0turtle tac0turtle merged commit eddb433 into master Jul 12, 2019
@melekes melekes deleted the 3744-fix-docs branch July 12, 2019 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants