abci: Refactor tagigng events using list of lists#3643
Merged
melekes merged 43 commits intotendermint:developfrom Jun 12, 2019
Merged
abci: Refactor tagigng events using list of lists#3643melekes merged 43 commits intotendermint:developfrom
melekes merged 43 commits intotendermint:developfrom
Conversation
golangcibot
reviewed
May 8, 2019
alexanderbez
commented
May 9, 2019
13 tasks
Codecov Report
@@ Coverage Diff @@
## develop #3643 +/- ##
===========================================
- Coverage 63.37% 63.33% -0.05%
===========================================
Files 218 218
Lines 18247 18220 -27
===========================================
- Hits 11564 11539 -25
+ Misses 5709 5705 -4
- Partials 974 976 +2
|
golangcibot
reviewed
May 13, 2019
Contributor
Author
|
@ebuchman @ethanfrey I've updated various tests, implemented new ones, and updated docs. Mind giving this another look? |
liamsi
approved these changes
Jun 7, 2019
Contributor
There was a problem hiding this comment.
LGTM, too!
I would hold off from merging until
#3643 (comment)
#3643 (comment)
are clarified / resolved.
This was referenced Jun 12, 2019
Merged
melekes
added a commit
that referenced
this pull request
Jun 12, 2019
Follow up to #3643 * update changelog * do not ignore errors returned by PublishWithEvents
4 tasks
|
if use the github.com/tendermint/tendermint v0.32.3, parse the transaction will error |
Contributor
|
You will need to switch to a new format (i.e. rename events := []types.Event{
{
Type: "app",
Attributes: []cmn.KVPair{
{Key: []byte("creator"), Value: []byte("Cosmoshi Netowoko")},
{Key: []byte("key"), Value: key},
},
},
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR introduces a fundamental breaking change to the structure of ABCI response and tx tags and the way they're processed. Namely, the SDK can support more complex and aggregated events for distribution and slashing. In addition, block responses can include duplicate keys in events.
Eventtype. An event has atypeand a list of KV pairs (ie. list-of-lists). Typical events may look like:The events are indexed by
{even.type}.{even.attribute[i].key}/.... In this case a client would subscribe or query forrewards.recipient='...'Events []Eventinstead ofTags []cmn.KVPair.map[string][]stringinstead ofmap[string]stringto support duplicate keys in response events (from Subscribing to tx event works for multiple kvpairs using same key #1385). A match is successful if the value is found in the slice of strings.closes: #1859
closes: #2905