Skip to content

Follow up to 3643#3722

Merged
melekes merged 2 commits intodevelopfrom
3643-follow-up
Jun 12, 2019
Merged

Follow up to 3643#3722
melekes merged 2 commits intodevelopfrom
3643-follow-up

Conversation

@melekes
Copy link
Contributor

@melekes melekes commented Jun 12, 2019

  • update changelog
  • do not ignore errors returned by PublishWithEvents

Refs #3643

@melekes melekes requested review from ebuchman and xla as code owners June 12, 2019 12:18
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@codecov-io
Copy link

Codecov Report

Merging #3722 into develop will decrease coverage by 0.12%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #3722      +/-   ##
===========================================
- Coverage    64.01%   63.88%   -0.13%     
===========================================
  Files          241      241              
  Lines        19948    19988      +40     
===========================================
  Hits         12770    12770              
- Misses        6139     6173      +34     
- Partials      1039     1045       +6
Impacted Files Coverage Δ
types/event_bus.go 53.78% <100%> (-0.77%) ⬇️
privval/signer_service_endpoint.go 83.63% <0%> (-5.46%) ⬇️
p2p/pex/pex_reactor.go 80.88% <0%> (-1.77%) ⬇️
blockchain/reactor.go 70.56% <0%> (-0.94%) ⬇️
consensus/state.go 79.73% <0%> (-0.83%) ⬇️
consensus/reactor.go 71.94% <0%> (-0.36%) ⬇️
blockchain/pool.go 80.26% <0%> (+0.65%) ⬆️
libs/db/remotedb/remotedb.go 40.83% <0%> (+4.93%) ⬆️

Copy link
Contributor

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@melekes melekes merged commit 9010ff5 into develop Jun 12, 2019
@melekes melekes deleted the 3643-follow-up branch June 12, 2019 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants