Merged
Conversation
patiee
pushed a commit
to graphprotocol/tendermint
that referenced
this pull request
Aug 7, 2023
… (backport tendermint#253) (tendermint#263) * Removing all the vuepress related build files and references (tendermint#253) * Removing all the vuepress related build files and references (tendermint#249) * Moved documentation ADR to deprecated (tendermint#249) * Reverting the logic for check-docs-toc until ADR/RFC refactor (tendermint#249) * Setting the right permissions to file so workflow executes (tendermint#249) * Reverting ADR change, will do in another issue (tendermint#249) (cherry picked from commit d159562) # Conflicts: # RELEASES.md # docs/.vuepress/config.js # docs/.vuepress/redirects # docs/DOCS_README.md # docs/package.json # docs/versions * fix for merge * fixing to merge --------- Co-authored-by: Andy Nogueira <me@andynogueira.dev> Co-authored-by: Daniel Cason <daniel.cason@informal.systems>
patiee
pushed a commit
to graphprotocol/tendermint
that referenced
this pull request
Aug 7, 2023
fixing backport to v0.37 related to (tendermint#263)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently unsubscribe is broken because it is using the event name instead of the listener to unsubscribe. This restores it to the functionality provided by:
https://github.com/eris-ltd/eris-db/blob/master/Godeps/_workspace/src/github.com/tendermint/tendermint/rpc/server/handlers.go#L359
As a side note the current code only allows one websocket subscription for the same remote address to the same event. This is probably a bad limitation to have. See my remark in: hyperledger-archives/burrow#235.