Conversation
f7f9d64 to
402f041
Compare
| cs.peerMsgQueue <- m | ||
| } | ||
|
|
||
| cs.handleMsg(m, cs.RoundState) |
Contributor
There was a problem hiding this comment.
was there a bug before where WAL entries would get duplicated?
Contributor
Author
There was a problem hiding this comment.
entries still get duplicated. we log before we even check if it applies.
Contributor
There was a problem hiding this comment.
it seems like it used to be more duplicated before: see https://github.com/tendermint/tendermint/blob/master/consensus/state.go#L613 where we save to WAL and then call handleMsg
Contributor
Author
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
oh, we used to also re-save logs during the replay, if that's what you're referring to, we no longer do that by not running the receiveRoutine and just calling handleMsg directly.
Contributor
|
looks good to me |
troian
pushed a commit
to akash-network/tendermint
that referenced
this pull request
Mar 11, 2023
… (backport tendermint#253) (tendermint#264) * Removing all the vuepress related build files and references (tendermint#253) * Removing all the vuepress related build files and references (tendermint#249) * Moved documentation ADR to deprecated (tendermint#249) * Reverting the logic for check-docs-toc until ADR/RFC refactor (tendermint#249) * Setting the right permissions to file so workflow executes (tendermint#249) * Reverting ADR change, will do in another issue (tendermint#249) (cherry picked from commit d159562) # Conflicts: # Makefile # RELEASES.md # docs/.vuepress/config.js # docs/.vuepress/redirects # docs/DOCS_README.md # docs/architecture/README.md # docs/package.json # docs/versions * fixing conflicts (tendermint#264) * remove comment leftover from git conflict resolution (tendermint#264) --------- Co-authored-by: Andy Nogueira <me@andynogueira.dev>
faddat
referenced
this pull request
in notional-labs/tendermint
Apr 3, 2023
* Removing all the vuepress related build files and references (#249) * Moved documentation ADR to deprecated (#249) * Reverting the logic for check-docs-toc until ADR/RFC refactor (#249) * Setting the right permissions to file so workflow executes (#249) * Reverting ADR change, will do in another issue (#249)
patiee
pushed a commit
to graphprotocol/tendermint
that referenced
this pull request
Aug 7, 2023
… (backport tendermint#253) (tendermint#263) * Removing all the vuepress related build files and references (tendermint#253) * Removing all the vuepress related build files and references (tendermint#249) * Moved documentation ADR to deprecated (tendermint#249) * Reverting the logic for check-docs-toc until ADR/RFC refactor (tendermint#249) * Setting the right permissions to file so workflow executes (tendermint#249) * Reverting ADR change, will do in another issue (tendermint#249) (cherry picked from commit d159562) # Conflicts: # RELEASES.md # docs/.vuepress/config.js # docs/.vuepress/redirects # docs/DOCS_README.md # docs/package.json # docs/versions * fix for merge * fixing to merge --------- Co-authored-by: Andy Nogueira <me@andynogueira.dev> Co-authored-by: Daniel Cason <daniel.cason@informal.systems>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coupled with the replay-WAL, this should prevent us from ever halting due to "losing a sig and not wanting to double sign".