Merge go-crypto into tendermint#1782
Merged
ebuchman merged 343 commits intotendermint:developfrom Jun 21, 2018
Merged
Conversation
cli improvements
makes TestListener never quit
crypto/hkdfchacha20poly1305/hkdfchachapoly_test.go:36:25:warning: should use make([]byte, 24) instead (S1019) (gosimple)
use tendermint/crypto :-)
Codecov Report
@@ Coverage Diff @@
## develop #1782 +/- ##
===========================================
- Coverage 62.59% 62.44% -0.16%
===========================================
Files 126 140 +14
Lines 11350 11875 +525
===========================================
+ Hits 7105 7415 +310
- Misses 3597 3769 +172
- Partials 648 691 +43
|
melekes
suggested changes
Jun 21, 2018
| "github.com/tendermint/tmlibs/log" | ||
| ) | ||
|
|
||
| ////////////////////////////////////////////////////////////////////////////// |
| require.Equal(t, http.StatusNotFound, res.StatusCode, "should always return 404") | ||
| } | ||
|
|
||
| ////////////////////////////////////////////////////////////////////////////// |
|
|
||
| // TimeFormat is used for generating the sigs | ||
| const TimeFormat = amino.RFC3339Millis | ||
| const TimeFormat = "2006-01-02T15:04:05.000Z" |
Contributor
There was a problem hiding this comment.
old version const TimeFormat = amino.RFC3339Millis is correct
Contributor
Author
There was a problem hiding this comment.
The version of amino this uses doesn't contain the constant anymore:
tendermint/go-amino@f81fa38
Contributor
There was a problem hiding this comment.
oh, sorry. this one --->>>
https://github.com/tendermint/tendermint/pull/1756/files#diff-2a5c02592829cd2adae17d586208b772
Contributor
Author
There was a problem hiding this comment.
Tests fail, if I do this change.
types/priv_validator.go
Outdated
| sig := pv.privKey.Sign(heartbeat.SignBytes(chainID)) | ||
| sig, err := pv.privKey.Sign(heartbeat.SignBytes(chainID)) | ||
| if err != nil { | ||
| panic(err) |
types/priv_validator.go
Outdated
| sig := pv.privKey.Sign(signBytes) | ||
| sig, err := pv.privKey.Sign(signBytes) | ||
| if err != nil { | ||
| panic(err) |
| signature = locPrivKey.Sign(challenge[:]) | ||
| signature, err := locPrivKey.Sign(challenge[:]) | ||
| if err != nil { | ||
| panic(err) |
Contributor
There was a problem hiding this comment.
can you add a todo to modify func to return err?
Contributor
Author
There was a problem hiding this comment.
Sure! Will do (and also open an issue so that doesn't get lost)
- re-add test - add TODO - err instead of panic where possible
Contributor
Author
|
Thanks for the review!! Addressed all your comments @melekes. PTAL |
melekes
reviewed
Jun 21, 2018
rpc/lib/server/handlers_test.go
Outdated
| defer s.Close() | ||
|
|
||
| // check upgrader works | ||
| d := websocket.Dialer{} |
Contributor
There was a problem hiding this comment.
what's up with formatting here?
Contributor
Author
There was a problem hiding this comment.
Somehow I disabled gofmt. Thanks
gofmt
melekes
approved these changes
Jun 21, 2018
Contributor
Author
ebuchman
approved these changes
Jun 21, 2018
| MaxPacketMsgPayloadSize int `mapstructure:"max_packet_msg_payload_size"` | ||
| // Maximum size of a message packet, in bytes | ||
| // Includes a header, which is ~13 bytes | ||
| MaxPacketMsgSize int `mapstructure:"max_packet_msg_size"` |
| plainHb := &Heartbeat{} | ||
| bz = plainHb.SignBytes("0xdeadbeef") | ||
| require.Equal(t, string(bz), `{"@chain_id":"0xdeadbeef","@type":"heartbeat","height":0,"round":0,"sequence":0,"validator_address":"","validator_index":0}`) | ||
| require.Equal(t, string(bz), `{"@chain_id":"0xdeadbeef","@type":"heartbeat","height":"0","round":"0","sequence":"0","validator_address":"","validator_index":"0"}`) |
Contributor
There was a problem hiding this comment.
so ints are strings now huh
2 tasks
cboh4
pushed a commit
to scrtlabs/tendermint
that referenced
this pull request
Apr 7, 2025
…1782) Otherwise, the events from app's BeginBlock won't be fired. Closes tendermint#1468 Co-authored-by: forcodedancing <just.haha.it@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
* [ ] Wrote testsdoesn't apply* [ ] Updated CHANGELOG.mdPart of #1309
Contains
a lotbasically all of changes from #1721