Change upstream go-crypto PrivKey API and update Amino version to 0.10.0#1721
Closed
Change upstream go-crypto PrivKey API and update Amino version to 0.10.0#1721
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change upstream go-crypto API to return errors on
Sign().This PR also removes
CGO_ENABLED=0- we need CGO for the upstreamgo-cryptonow, along with CLevelDB in the future - and adds amake build_dockercommand for binary-hash-reproducible builds. Note that the binary is dynamically linked, so users wishing to completely reproduce builds will need to link the same version of libc which ships with thegolangDocker container.As this includes the new Amino version, this is breaking, especially for
priv_validator.json(Amino encoding of int/int64 changed to strings).Closes #1545.