Update ABCI for new PubKey type and changes to BeginBlock and InitChain#1667
Merged
Update ABCI for new PubKey type and changes to BeginBlock and InitChain#1667
Conversation
melekes
approved these changes
Jun 1, 2018
Contributor
|
Supersedes most of #1582, can we cherry-pick the last few commits (adding a |
Contributor
Author
|
Yeh let's do it. Damn looks like I need to fix some tests. |
ebuchman
commented
Jun 2, 2018
state/execution.go
Outdated
| // `SetValidatorSet()` and `ToABCI` methods ? | ||
| valset, err := LoadValidators(stateDB, ev.Height()) | ||
| if err != nil { | ||
| panic(err) // shoudn't happen |
types/protobuf.go
Outdated
| switch pk := pubKey.(type) { | ||
| case crypto.PubKeyEd25519: | ||
| return abci.PubKey{ | ||
| Type: "ed25519", |
types/protobuf.go
Outdated
| } | ||
| case crypto.PubKeySecp256k1: | ||
| return abci.PubKey{ | ||
| Type: "secp256k1", |
Contributor
Author
|
@cwgoes is this everything you need ? |
This was referenced Jun 2, 2018
Codecov Report
@@ Coverage Diff @@
## develop #1667 +/- ##
==========================================
Coverage ? 62.31%
==========================================
Files ? 123
Lines ? 11146
Branches ? 0
==========================================
Hits ? 6946
Misses ? 3582
Partials ? 618
|
Contributor
Yes, I think so, updated downstream in cosmos/cosmos-sdk#1115. |
This was referenced Jun 4, 2018
Closed
…rt to abci.Evidence
firelizzard18
pushed a commit
to AccumulateNetwork/tendermint
that referenced
this pull request
Feb 1, 2024
* address Bucky comments also add a tracking issue * fix indentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to the latest ABCI with new:
Still a couple TODOs left