Skip to content

WIP: Update to new ABCI#1582

Closed
cwgoes wants to merge 9 commits intodevelopfrom
cwgoes/update-abci
Closed

WIP: Update to new ABCI#1582
cwgoes wants to merge 9 commits intodevelopfrom
cwgoes/update-abci

Conversation

@cwgoes
Copy link
Contributor

@cwgoes cwgoes commented May 16, 2018

Can wait for ABCI release before merge, need for SDK slashing implementation.

@cwgoes cwgoes requested review from ebuchman and melekes as code owners May 16, 2018 13:22
@cwgoes cwgoes force-pushed the cwgoes/update-abci branch from b5aa398 to f5c7513 Compare May 16, 2018 14:10
@cwgoes cwgoes changed the base branch from develop to 847-separate-internal-pubsub May 16, 2018 14:11
@cwgoes
Copy link
Contributor Author

cwgoes commented May 16, 2018 •
edited
Loading

To-do:

  • Pass full genesis state to RequestInitChain
  • Track state updates in replayBlocks and use state.ApplyBlock instead of ExecCommitBlock

@melekes melekes force-pushed the 847-separate-internal-pubsub branch from c0b4fda to a9d0adb Compare May 21, 2018 06:56
@cwgoes cwgoes mentioned this pull request May 23, 2018
Closed
19 tasks
@cwgoes cwgoes changed the base branch from 847-separate-internal-pubsub to develop May 28, 2018 22:13
@cwgoes cwgoes mentioned this pull request May 28, 2018
Merged
@cwgoes cwgoes force-pushed the cwgoes/update-abci branch from d309342 to 99a7086 Compare May 28, 2018 22:35
@codecov-io
Copy link

codecov-io commented May 28, 2018 •
edited
Loading

Codecov Report

Merging #1582 into develop will decrease coverage by 0.79%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           develop    #1582     +/-   ##
==========================================
- Coverage    62.26%   61.47%   -0.8%     
==========================================
  Files          121      121             
  Lines        11094    11097      +3     
==========================================
- Hits          6908     6822     -86     
- Misses        3570     3655     +85     
- Partials       616      620      +4
Impacted Files Coverage Δ
state/execution.go 71.18% <100%> (+0.32%) ⬆️
consensus/replay.go 54.12% <100%> (ø) ⬆️
p2p/pex/pex_reactor.go 65.14% <0%> (-7.17%) ⬇️
consensus/reactor.go 72.55% <0%> (-5.76%) ⬇️
p2p/node_info.go 44.82% <0%> (-5.18%) ⬇️
evidence/reactor.go 63.23% <0%> (-2.95%) ⬇️
mempool/reactor.go 64.93% <0%> (-2.6%) ⬇️
p2p/listener.go 50% <0%> (-1.93%) ⬇️
consensus/state.go 75.9% <0%> (-1.68%) ⬇️
blockchain/pool.go 68.05% <0%> (-1.53%) ⬇️
... and 8 more

@cwgoes cwgoes force-pushed the cwgoes/update-abci branch from 99a7086 to 849ffaf Compare May 28, 2018 23:03
@cwgoes cwgoes force-pushed the cwgoes/update-abci branch from c52bf60 to 3b8c1ae Compare May 29, 2018 02:59
@cwgoes cwgoes force-pushed the cwgoes/update-abci branch 4 times, most recently from 9cc39a2 to fc13008 Compare May 31, 2018 04:33
@cwgoes cwgoes force-pushed the cwgoes/update-abci branch from fc13008 to 73de99e Compare May 31, 2018 04:35
@cwgoes
Copy link
Contributor Author

cwgoes commented Jun 1, 2018 •
edited
Loading

This should include a fix for cosmos/cosmos-sdk#1103 before being merged

@cwgoes cwgoes mentioned this pull request Jun 1, 2018
Merged
@ebuchman
Copy link
Contributor

ebuchman commented Jun 2, 2018

Thanks Chris! Should be replaced by #1667

@ebuchman ebuchman closed this Jun 2, 2018
@cwgoes cwgoes deleted the cwgoes/update-abci branch June 2, 2018 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ebuchman ebuchman Awaiting requested review from ebuchman

@melekes melekes Awaiting requested review from melekes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cwgoes @codecov-io @ebuchman