Skip to content

standardize PRNG access#1411

Merged
melekes merged 4 commits intotendermint:developfrom
Tilkal:1343-standardize-rand
Apr 11, 2018
Merged

standardize PRNG access#1411
melekes merged 4 commits intotendermint:developfrom
Tilkal:1343-standardize-rand

Conversation

@tomc974
Copy link
Contributor

@tomc974 tomc974 commented Apr 3, 2018

Fixes #1343
Depends on tendermint/tmlibs#191 tendermint/tmlibs#194

Replaces usage of math/rand with tmlibs equivalent in non-test files.

Should we also replace math/rand in test files?

@tomc974 tomc974 requested review from ebuchman and melekes as code owners April 3, 2018 15:08
@tomc974
Copy link
Contributor Author

tomc974 commented Apr 4, 2018

Now that tmlibs dependencies have been merged, could someone re-run the CI?

@melekes
Copy link
Contributor

melekes commented Apr 4, 2018

You can update tmlibs yourself by executing dep ensure -update github.com/tendermint/tmlibs.

@tomc974
Copy link
Contributor Author

tomc974 commented Apr 4, 2018

@melekes Yeah, I know how to upgrade tmlibs locally, but I can't re-run the Circle CI tests to update the CI status of the merge request which failed because of missing methods in tmlibs.

@melekes
Copy link
Contributor

melekes commented Apr 4, 2018

  1. dep ensure -update ...
  2. commit newer Gopkg.lock
  3. profit 👍

@tomc974
Copy link
Contributor Author

tomc974 commented Apr 4, 2018

Oh I see, thanks!

@melekes
Copy link
Contributor

melekes commented Apr 5, 2018

codecov 😞

@tomc974
Copy link
Contributor Author

tomc974 commented Apr 5, 2018

Anything I should do about the codecov issue?

@melekes melekes merged commit ab00bf7 into tendermint:develop Apr 11, 2018
@melekes
Copy link
Contributor

melekes commented Apr 11, 2018

🥇 🏎 🍰

@tomc974 tomc974 deleted the 1343-standardize-rand branch April 11, 2018 15:33
firelizzard18 pushed a commit to AccumulateNetwork/tendermint that referenced this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants