Skip to content

Follow-ups to PrivValidator#1284

Merged
ebuchman merged 5 commits intodevelopfrom
feature/xla-follow-priv-val
Mar 6, 2018
Merged

Follow-ups to PrivValidator#1284
ebuchman merged 5 commits intodevelopfrom
feature/xla-follow-priv-val

Conversation

@xla
Copy link
Contributor

@xla xla commented Mar 6, 2018

Incorporates feedback from #1203 and is part of #1255.

@xla xla added the T:validator Type: Validator related label Mar 6, 2018
@xla xla self-assigned this Mar 6, 2018
@xla xla requested review from ebuchman and melekes March 6, 2018 15:25
@codecov-io
Copy link

codecov-io commented Mar 6, 2018

Codecov Report

Merging #1284 into develop will increase coverage by 0.1%.
The diff coverage is 68.18%.

@@            Coverage Diff             @@
##           develop    #1284     +/-   ##
==========================================
+ Coverage    60.54%   60.64%   +0.1%     
==========================================
  Files          112      112             
  Lines        10860    10863      +3     
==========================================
+ Hits          6575     6588     +13     
+ Misses        3648     3639      -9     
+ Partials       637      636      -1
Impacted Files Coverage Δ
node/node.go 63.27% <0%> (-0.6%) ⬇️
types/priv_validator/json.go 59.52% <25%> (ø) ⬆️
types/priv_validator/socket.go 64.21% <93.33%> (ø) ⬆️
consensus/state.go 77.67% <0%> (-0.14%) ⬇️
p2p/peer.go 63.38% <0%> (ø) ⬆️
p2p/conn/connection.go 82.62% <0%> (+0.28%) ⬆️
p2p/pex/pex_reactor.go 66.66% <0%> (+0.4%) ⬆️
consensus/reactor.go 74.25% <0%> (+1.7%) ⬆️

@xla xla force-pushed the feature/xla-follow-priv-val branch from f08b2f1 to 2aa7702 Compare March 6, 2018 19:00
@ebuchman ebuchman merged commit 2ce57a6 into develop Mar 6, 2018
@ebuchman ebuchman deleted the feature/xla-follow-priv-val branch March 6, 2018 22:37
firelizzard18 pushed a commit to AccumulateNetwork/tendermint that referenced this pull request Feb 1, 2024
* cannot load state error

* wip: migrate Errorf to exported

* export errors.New errors

* export remaining errors

* selfrev: remove not-needed comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T:validator Type: Validator related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants