Skip to content

PrivValidator follow up #1255

New issue
New issue
Closed
Closed
PrivValidator follow up#1255
Assignees
xla
Labels
T:validatorType: Validator related
Milestone
launch
@ebuchman

Description

@ebuchman
ebuchman
opened on Feb 28, 2018
  • types/priv_validator package #1203 has been merged but please follow up on Anton's review re pvsc.Stop(), panic, and sign_bytes
  • Tendermint is dialing the signer, but we need the signer to dial Tendermint. Perhaps we can have the SocketClient take a conn directly to avoid the confusion around a client doing the listening (the ADR did not specify this well, my bad - see PrivValidatorAddr -> PrivValidatorListenAddr. Update ADR008 #1256 for a start)
  • Some more review follow up from Invert privVal socket communication #1286 (review)
  • priv_val_server needs to be updated
  • authenticate against ID@host:port in the RemoteSigner, check that id matches configured
  • Persist PrivKey the SocketClient uses for external signers to authenticate properly
  • full integration and deprecate the old PrivValidator

Metadata

Metadata

Assignees

Labels

T:validatorType: Validator related

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions