Conversation
Include overview and configuration options.
b308b3a to
7b52499
Compare
|
|
||
| `--mempool.recheck=false` (default: true) | ||
|
|
||
| `--mempool.recheck_empty=false` (default: true) |
There was a problem hiding this comment.
@ebuchman Do we want to make this false by default?
mempool.go:368 suggests it is used for debugging
There was a problem hiding this comment.
Maybe. But currently the mempool is supposed to be configured so a correct proposer will only propose valid txs. Apps that use EndBlock could invalidate transactions in the mempool without the mempool knowing, and so a correct proposer could return invalid txs.
We just need to be clear either way. There's def a performance benefit to setting it false (ie. we won't replay all our mempool txs when an empty block is committed ...)
Codecov Report
@@ Coverage Diff @@
## develop #1056 +/- ##
===========================================
- Coverage 59.95% 59.72% -0.23%
===========================================
Files 116 116
Lines 10667 10667
===========================================
- Hits 6395 6371 -24
- Misses 3701 3721 +20
- Partials 571 575 +4 |
|
|
||
| Mempool exposes `CheckTx([]byte)` over the RPC interface. | ||
|
|
||
| It can be posted via `broadcast_commit`, `broadcast_sync` or |
There was a problem hiding this comment.
these are not the same things... broadcast_commit calls both CheckTx and waits for DeliverTx result. not sure this should be here. i think this belongs to RPC API!
|
Merging, will clean up later |
|
do we want any of these rendered in RTD? |
* Update the annotation of part_set.go * Update types/part_set.go Co-authored-by: Sergio Mena <sergio@informal.systems> --------- Co-authored-by: Mansub Song <60084364+mansub1029@users.noreply.github.com> Co-authored-by: Sergio Mena <sergio@informal.systems>
Writing a public specification of the mempool module.