Config Improvements by zramsay · Pull Request #792 · tendermint/tendermint

zramsay · 2017-10-26T23:23:51Z

codecov-io · 2017-10-26T23:23:54Z

Codecov Report

Merging #792 into develop will decrease coverage by 0.06%.
The diff coverage is 48.57%.

@@             Coverage Diff             @@
##           develop     #792      +/-   ##
===========================================
- Coverage    59.89%   59.82%   -0.07%     
===========================================
  Files          116      116              
  Lines        10748    10761      +13     
===========================================
+ Hits          6437     6438       +1     
- Misses        3730     3742      +12     
  Partials       581      581

melekes · 2017-10-27T09:24:22Z

Tests failed with:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x902469]

goroutine 41 [running]:
github.com/tendermint/tendermint/rpc/lib/client.callWgDoneOnResult(0xc4201ce3c0, 0xc42009f7a0, 0xc42019d870)
        /go/src/github.com/tendermint/tendermint/rpc/lib/client/ws_client_test.go:207 +0x1a9
created by github.com/tendermint/tendermint/rpc/lib/client.TestWSClientReconnectsAfterWriteFailure
        /go/src/github.com/tendermint/tendermint/rpc/lib/client/ws_client_test.go:100 +0x192
exit status 2
FAIL    github.com/tendermint/tendermint/rpc/lib/client 2.339s

but this seems to be not related. I will take a look

#792 (comment) ``` panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x902469] goroutine 41 [running]: github.com/tendermint/tendermint/rpc/lib/client.callWgDoneOnResult(0xc4201ce3c0, 0xc42009f7a0, 0xc42019d870) /go/src/github.com/tendermint/tendermint/rpc/lib/client/ws_client_test.go:207 +0x1a9 created by github.com/tendermint/tendermint/rpc/lib/client.TestWSClientReconnectsAfterWriteFailure /go/src/github.com/tendermint/tendermint/rpc/lib/client/ws_client_test.go:100 +0x192 exit status 2 FAIL github.com/tendermint/tendermint/rpc/lib/client 2.339s ```

melekes · 2017-10-30T16:27:55Z

test/app/test.sh: line 80: 13549 Killed                  abci-cli counter --serial --abci grpc > /dev/null
test/app/test.sh: line 80: 13550 Killed                  tendermint node --abci grpc > tendermint.log
Starting counter_over_grpc_grpc (ie. with grpc broadcast_tx)
running test
... sending tx. expect no error
... building grpc_client
RESPONSE
rpc error: code = Unavailable desc = grpc: the connection is unavailable
parse error: Invalid numeric literal at line 1, column 4
parse error: Invalid numeric literal at line 1, column 4
-------
TX 00
RESPONSE rpc error: code = Unavailable desc = grpc: the connection is unavailable
ERROR rpc error: code = Unavailable desc = grpc: the connection is unavailable
----
Unexpected error sending tx (00): rpc error: code = Unavailable desc = grpc: the connection is unavailable

zramsay · 2017-11-06T18:35:20Z

hmm, i ran ./test/app/test.sh and got

Running all
Starting dummy_over_socket
running test
0x616263643D64636261

melekes · 2017-11-06T20:48:26Z

The tests behave themselves very strange. Every time I am rebuilding this, they fail with a new error.

melekes · 2017-12-02T04:24:55Z

config/config.go

 func DefaultConsensusConfig() *ConsensusConfig {
 	return &ConsensusConfig{
-		WalPath:                     "data/cs.wal/wal",
+		WalPath:                     filepath.Join(defaultDataDir, "cs.wal/wal"),


filepath.Join(defaultDataDir, "cs.wal", "wal")

melekes · 2017-12-02T04:26:47Z

config/toml.go

+filter_peers = {{ .BaseConfig.FilterPeers }}
+
+# What indexer to use for transactions
+tx_index = "{{ .BaseConfig.TxIndex }}"


this moved to its own section [tx_index]

melekes · 2017-12-02T04:28:47Z

docs/specification/configuration.rst

+    filter_peers = false
+
+    # What indexer to use for transactions
+    tx_index = "kv"


melekes · 2017-12-02T15:30:23Z

2017-12-02T05:48:17Z box1393.localdomain docker/local_testnet_1[14895]: ERROR: Failed to create node: Couldn't read GenesisDoc file: open /go/src/github.com/tendermint/tendermint/test/p2p/data/mach1/core/config/genesis.json: no such file or directory

melekes · 2017-12-02T17:52:34Z

also, dockerfile needs to be updated here

melekes · 2017-12-10T17:41:40Z

# github.com/tendermint/tendermint/config
config/toml.go:38:44: undefined: defaultConfig
config/toml.go:244:44: undefined: testConfig

zramsay · 2017-12-10T17:47:25Z

on it

ebuchman · 2017-12-11T01:26:59Z

docs/specification/configuration.rst

+``$TMHOME/config/config.toml``. Some of these parameters can be overridden by
+command-line flags. For most users, the options in the ``##### main
+base configuration options #####`` are intended to be modified while
+config options further below are intended for advance power users.


not quite true. theres stuff like p2p.seeds that the average user should be manipualting

zramsay · 2017-12-11T13:04:01Z

currently hangs in the CI

config: test the default file docs: spiff up config config: minor fixes & comments config: simplify test config; use a seperate config directory, #556 config: update docs & parameterize file paths config: PR comments config: use the default object fix a rebase error

zramsay · 2018-01-10T15:03:16Z

narrowed down the test failure when rebasing this branch on the jenkins branch: https://ci.interblock.io/job/05.Test.Tendermint.FeatureBranches.p2p/98/console
see the branch config-on-jenkins

zramsay · 2018-01-10T15:43:26Z

same error when running locally

zramsay · 2018-01-10T16:47:25Z

boom: fixed with latest commit https://ci.interblock.io/job/05.Test.Tendermint.FeatureBranches.p2p/100/console

…0.34.x chore: pull latest v0.34.x

* Unsafe int cast in `kill` command * Revert "Unsafe int cast in `kill` command" This reverts commit bbd649bd372ca90f83dea7b424d67dafbd9eb541. * Changed strategy (cherry picked from commit 03c5e77) Co-authored-by: Sergio Mena <sergio@informal.systems>

zramsay requested a review from ebuchman as a code owner October 26, 2017 23:23

zramsay force-pushed the config branch from 376dfe0 to 05c6322 Compare October 26, 2017 23:31

melekes approved these changes Oct 27, 2017

View reviewed changes

zramsay added this to the 0.13.0 milestone Oct 28, 2017

zramsay force-pushed the config branch from 7a7e083 to abdc20e Compare October 28, 2017 14:08

melekes mentioned this pull request Nov 16, 2017

Document "various" mempool parameters #855

Closed

zramsay self-assigned this Dec 1, 2017

melekes force-pushed the config branch 2 times, most recently from 03fc4e5 to 2dd47ea Compare December 2, 2017 04:22

melekes suggested changes Dec 2, 2017

View reviewed changes

melekes approved these changes Dec 2, 2017

View reviewed changes

melekes force-pushed the config branch from 20f9245 to 40d7faa Compare December 2, 2017 17:28

ebuchman modified the milestones: 0.13.0, 0.14.0 Dec 6, 2017

zramsay force-pushed the config branch from 40d7faa to ef4fe9c Compare December 10, 2017 17:33

zramsay added the breaking label Dec 10, 2017

ebuchman reviewed Dec 11, 2017

View reviewed changes

zramsay mentioned this pull request Dec 11, 2017

config: address breaking tmint change cosmos/cosmos-sdk#299

Closed

ebuchman force-pushed the config branch from a4ec823 to 29534ea Compare December 27, 2017 20:33

ebuchman approved these changes Dec 27, 2017

View reviewed changes

zramsay and others added 6 commits December 28, 2017 20:49

fixes after my own review

69d8c2e

move genesis.json file into config dir

a6f2e50

rebase fix

9da5cd0

config: lil fixes

a92a32b

config: unexpose chainID

a8e625e

zramsay force-pushed the config branch from 29534ea to a8e625e Compare December 28, 2017 20:49

jaekwon removed the breaking label Jan 6, 2018

Merge branch 'develop' into config

e0e600d

zramsay modified the milestones: 0.15.0, 0.16.0 Jan 6, 2018

melekes mentioned this pull request Jan 8, 2018

WIP: Mempool specification #1056

Merged

Merge branch 'develop' into config

39acf1c

p2p tests: put priv_val in right place

657ad21

zramsay mentioned this pull request Jan 10, 2018

Build & distribution process suggestions #1090

Closed

ebuchman approved these changes Jan 10, 2018

View reviewed changes

ebuchman merged commit a13b17e into develop Jan 10, 2018

zramsay mentioned this pull request Jan 10, 2018

commands, config: tally and report unknown fields in config #636

Closed

zramsay deleted the config branch January 10, 2018 19:49

zramsay mentioned this pull request Feb 2, 2018

split immutable and mutable parts of priv_validator.json #1181

Closed

cmwaters pushed a commit to cmwaters/tendermint that referenced this pull request Dec 12, 2022

Merge pull request tendermint#792 from celestiaorg/evan/pull-latest-v…

e5a89b7

…0.34.x chore: pull latest v0.34.x

Conversation

zramsay commented Oct 26, 2017

Uh oh!

codecov-io commented Oct 26, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melekes commented Oct 27, 2017

Uh oh!

melekes commented Oct 30, 2017

Uh oh!

zramsay commented Nov 6, 2017

Uh oh!

melekes commented Nov 6, 2017

Uh oh!

melekes Dec 2, 2017

Choose a reason for hiding this comment

Uh oh!

melekes Dec 2, 2017

Choose a reason for hiding this comment

Uh oh!

melekes Dec 2, 2017

Choose a reason for hiding this comment

Uh oh!

melekes commented Dec 2, 2017

Uh oh!

melekes commented Dec 2, 2017

Uh oh!

melekes commented Dec 10, 2017

Uh oh!

zramsay commented Dec 10, 2017

Uh oh!

ebuchman Dec 11, 2017

Choose a reason for hiding this comment

Uh oh!

zramsay commented Dec 11, 2017

Uh oh!

zramsay commented Jan 10, 2018

Uh oh!

zramsay commented Jan 10, 2018

Uh oh!

zramsay commented Jan 10, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov-io commented Oct 26, 2017 •

edited

Loading