Skip to content

Fix stale k8s.io/client-go version in go.mod#2585

Merged
chmouel merged 1 commit intotektoncd:mainfrom
dsimansk:pr/fix-stale-version
Mar 18, 2026
Merged

Fix stale k8s.io/client-go version in go.mod#2585
chmouel merged 1 commit intotektoncd:mainfrom
dsimansk:pr/fix-stale-version

Conversation

@dsimansk
Copy link
Copy Markdown
Contributor

📝 Description of the Change

🔗 Linked GitHub Issue

Very similar to this version clean up tektoncd/cli#1717

In conjunction with replace directive for client-go the stale version value is never update automatically, even thought that the original requiring dep moved on (due to semver major being 1.y.z > 0.y.z).

This is more of a cosmetic change from perspective of pipeline-as-code repo, but being required forces consuming project downstream to have this stale client-go version into go.mod by the go toolchain.

🧪 Testing Strategy

  • Unit tests
  • Integration tests
  • End-to-end tests
  • Manual testing
  • Not Applicable

🤖 AI Assistance

AI assistance can be used for various tasks, such as code generation,
documentation, or testing.

Please indicate whether you have used AI assistance
for this PR and provide details if applicable.

  • I have not used any AI assistance for this PR.
  • I have used AI assistance for this PR.

Important

Slop will be simply rejected, if you are using AI assistance you need to make sure you
understand the code generated and that it meets the project's standards. you
need at least know how to run the code and deploy it (if needed). See
startpaac to make it easy
to deploy and test your code changes.

If the majority of the code in this PR was generated by an AI, please add a Co-authored-by trailer to your commit message.
For example:

Co-authored-by: Claude noreply@anthropic.com

✅ Submitter Checklist

  • 📝 My commit messages are clear, informative, and follow the project's How to write a git commit message guide. The Gitlint linter ensures in CI it's properly validated
  • ✨ I have ensured my commit message prefix (e.g., fix:, feat:) matches the "Type of Change" I selected above.
  • ♽ I have run make test and make lint locally to check for and fix any
    issues. For an efficient workflow, I have considered installing
    pre-commit and running pre-commit install to
    automate these checks.
  • 📖 I have added or updated documentation for any user-facing changes.
  • 🧪 I have added sufficient unit tests for my code changes.
  • 🎁 I have added end-to-end tests where feasible. See README for more details.
  • 🔎 I have addressed any CI test flakiness or provided a clear reason to bypass it.
  • If adding a provider feature, I have filled in the following and updated the provider documentation:
    • GitHub App
    • GitHub Webhook
    • Gitea/Forgejo
    • GitLab
    • Bitbucket Cloud
    • Bitbucket Data Center

@chmouel
Copy link
Copy Markdown
Member

chmouel commented Mar 18, 2026

/ok-to-test

@chmouel
Copy link
Copy Markdown
Member

chmouel commented Mar 18, 2026

thanks!

we need to revise all our pinning when we will do our deps update

@chmouel chmouel merged commit d7b0258 into tektoncd:main Mar 18, 2026
3 checks passed
@chmouel
Copy link
Copy Markdown
Member

chmouel commented Mar 18, 2026

followup here #2586

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants