Skip to content

chore: remove a bunch go.mod replace directives#2586

Merged
chmouel merged 1 commit intotektoncd:mainfrom
chmouel:remove-pinning
Mar 18, 2026
Merged

chore: remove a bunch go.mod replace directives#2586
chmouel merged 1 commit intotektoncd:mainfrom
chmouel:remove-pinning

Conversation

@chmouel
Copy link
Copy Markdown
Member

@chmouel chmouel commented Mar 18, 2026

📝 Description of the Change

  • Remove unused github.com/google/gofuzz and github.com/gogo/protobuf dependencies.
  • Add sigs.k8s.io/structured-merge-diff/v6 to track the updated version.
  • Remove redundant sigs.k8s.io/structured-merge-diff/v4 dependency.
  • Remove multiple replace directives that are no longer required for dependency resolution.
  • some upgrade of kubernetes generated linter errors that has beenfixed:
    pkg/llm/analyzer_test.go:23:16: SA1019: fake.NewSimpleClientset is
    deprecated:

knative one are still doing replace since i guess the move to opencensus
is not done yet.

This cleanup improves the build configuration by removing stale dependencies and outdated overrides, aligning the project closer to current Kubernetes upstream library versions.

🔗 Linked GitHub Issue

Fixes #

🧪 Testing Strategy

  • Unit tests
  • Integration tests
  • End-to-end tests
  • Manual testing
  • Not Applicable

🤖 AI Assistance

AI assistance can be used for various tasks, such as code generation,
documentation, or testing.

Please indicate whether you have used AI assistance
for this PR and provide details if applicable.

  • I have used AI assistance for this PR.
  • I have not used any AI assistance for this PR.

Important

Slop will be simply rejected, if you are using AI assistance you need to make sure you
understand the code generated and that it meets the project's standards. you
need at least know how to run the code and deploy it (if needed). See
startpaac to make it easy
to deploy and test your code changes.

If the majority of the code in this PR was generated by an AI, please add a Co-authored-by trailer to your commit message.
For example:

Co-authored-by: Claude noreply@anthropic.com

✅ Submitter Checklist

  • 📝 My commit messages are clear, informative, and follow the project's How to write a git commit message guide. The Gitlint linter ensures in CI it's properly validated
  • ✨ I have ensured my commit message prefix (e.g., fix:, feat:) matches the "Type of Change" I selected above.
  • ♽ I have run make test and make lint locally to check for and fix any
    issues. For an efficient workflow, I have considered installing
    pre-commit and running pre-commit install to
    automate these checks.
  • 📖 I have added or updated documentation for any user-facing changes.
  • 🧪 I have added sufficient unit tests for my code changes.
  • 🎁 I have added end-to-end tests where feasible. See README for more details.
  • 🔎 I have addressed any CI test flakiness or provided a clear reason to bypass it.
  • If adding a provider feature, I have filled in the following and updated the provider documentation:
    • GitHub App
    • GitHub Webhook
    • Gitea/Forgejo
    • GitLab
    • Bitbucket Cloud
    • Bitbucket Data Center

- Remove unused `github.com/google/gofuzz` and `github.com/gogo/protobuf` dependencies.
- Add `sigs.k8s.io/structured-merge-diff/v6` to track the updated version.
- Remove redundant `sigs.k8s.io/structured-merge-diff/v4` dependency.
- Remove multiple `replace` directives that are no longer required for dependency resolution.
- some upgrade of kubernetes generated linter errors that has beenfixed:
  pkg/llm/analyzer_test.go:23:16: SA1019: fake.NewSimpleClientset is
  deprecated:

knative one are still doing replace since i guess the move to opencensus
is not done yet.

This cleanup improves the build configuration by removing stale dependencies and outdated overrides, aligning the project closer to current Kubernetes upstream library versions.

Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
@chmouel chmouel merged commit f973266 into tektoncd:main Mar 18, 2026
13 checks passed
@chmouel chmouel deleted the remove-pinning branch March 18, 2026 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants