Skip to content

Align client-go to rest of K8s dependencies#1717

Merged
tekton-robot merged 1 commit intotektoncd:mainfrom
dsimansk:pr/bump-client-go
Sep 19, 2022
Merged

Align client-go to rest of K8s dependencies#1717
tekton-robot merged 1 commit intotektoncd:mainfrom
dsimansk:pr/bump-client-go

Conversation

@dsimansk
Copy link
Copy Markdown
Contributor

@dsimansk dsimansk commented Sep 19, 2022 •
edited
Loading

Changes

This PR aligns require directive of go.mod to the rest of Kubernetes dependencies. The actual version has been already used though replace. However, being "required" is making go modules to enforce it during import, e.g. knative-sanbox/kn-plugin-func project.

I haven't noticed any issues with running the standards checks. Please let me know if I missed anything.

https://github.com/knative-sandbox/kn-plugin-func/blob/main/go.mod#L46

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 19, 2022
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Sep 19, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: dsimansk / name: David Simansky (b7ff0a9)

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 19, 2022
@tekton-robot
Copy link
Copy Markdown
Contributor

tekton-robot commented Sep 19, 2022

Hi @dsimansk. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 19, 2022
@vdemeester
Copy link
Copy Markdown
Member

vdemeester commented Sep 19, 2022

/ok-to-test
/approve

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 19, 2022
@tekton-robot
Copy link
Copy Markdown
Contributor

tekton-robot commented Sep 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2022
pradeepitm12
pradeepitm12 reviewed Sep 19, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@pradeepitm12 pradeepitm12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2022
@tekton-robot tekton-robot merged commit c1f98c8 into tektoncd:main Sep 19, 2022
@dsimansk dsimansk mentioned this pull request Sep 23, 2022
Merged
@dsimansk dsimansk deleted the pr/bump-client-go branch September 23, 2022 14:07
@dsimansk dsimansk mentioned this pull request Aug 28, 2023
Merged
@dsimansk dsimansk mentioned this pull request Mar 18, 2026
Merged
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hrishin hrishin Awaiting requested review from hrishin

@vinamra28 vinamra28 Awaiting requested review from vinamra28

1 more reviewer

@pradeepitm12 pradeepitm12 pradeepitm12 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@pradeepitm12 pradeepitm12

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dsimansk @tekton-robot @vdemeester @pradeepitm12